Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v18.x backport] deps: add loongarch64 into openssl Makefile and gen openssl-loongarch64 #48135

Closed

Conversation

shipujin
Copy link
Member

@shipujin shipujin commented May 23, 2023

Add linux64-loongarch64 into Makefile
And run make

PR-URL: #46401
Backport-PR-URL: #48135
Reviewed-By: Ben Noordhuis info@bnoordhuis.nl
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Michael Dawson midawson@redhat.com

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. labels May 23, 2023
@shipujin
Copy link
Member Author

Add linux64-loongarch64 into Makefile
And run make

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51993/

@shipujin
Copy link
Member Author

Update

@nodejs-github-bot
Copy link
Collaborator

@shipujin
Copy link
Member Author

Hi @danielleadams ,I have verified and updated this patch on my computer. Could you please help review this patch.
thx~

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52723/

@Trott
Copy link
Member

Trott commented Aug 3, 2023

@ruyadorno Is this something that might end up in the next 18.x release. (According to nodejs/Release#737, you're doing the 18.x release for August 2023. Apologies if I'm doing things wrong and you're not the person to ping!)

ruyadorno pushed a commit that referenced this pull request Aug 16, 2023
Add linux64-loongarch64 into Makefile
And run make

PR-URL: #46401
Backport-PR-URL: #48135
Reviewed-By: Ben Noordhuis info@bnoordhuis.nl
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Michael Dawson midawson@redhat.com
@ruyadorno
Copy link
Member

Landed in f4617a4

@ruyadorno ruyadorno closed this Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants