Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: add security-wg as dep updaters owner #48113

Merged
merged 3 commits into from
May 24, 2023
Merged

tools: add security-wg as dep updaters owner #48113

merged 3 commits into from
May 24, 2023

Conversation

marco-ippolito
Copy link
Member

@marco-ippolito marco-ippolito commented May 22, 2023 •
edited
Loading

Refs: nodejs/security-wg#828
Added security-wg as codeowner of dep updaters

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label May 22, 2023
richardlau
richardlau reviewed May 22, 2023
View reviewed changes
.github/CODEOWNERS Outdated Show resolved Hide resolved
RafaelGSS
RafaelGSS approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with @richardlau suggestion

Trott
Trott reviewed May 22, 2023
View reviewed changes
.github/CODEOWNERS Outdated Show resolved Hide resolved
@marco-ippolito @Trott
Update .github/CODEOWNERS
7ef022e 
Co-authored-by: Rich Trott <rtrott@gmail.com>
@Trott Trott added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label May 23, 2023
@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label May 23, 2023
@marco-ippolito marco-ippolito added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels May 24, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 24, 2023
@nodejs-github-bot nodejs-github-bot merged commit bcf1dd0 into nodejs:main May 24, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in bcf1dd0

targos pushed a commit that referenced this pull request May 30, 2023
@marco-ippolito @targos
tools: add security-wg as dep updaters owner
8d93af3 
PR-URL: #48113
Refs: nodejs/security-wg#828
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Jun 4, 2023
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@marco-ippolito @danielleadams
tools: add security-wg as dep updaters owner
6132602 
PR-URL: #48113
Refs: nodejs/security-wg#828
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@marco-ippolito @MoLow
tools: add security-wg as dep updaters owner
e18c125 
PR-URL: nodejs#48113
Refs: nodejs/security-wg#828
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@marco-ippolito @Ceres6
tools: add security-wg as dep updaters owner
5a8fe88 
PR-URL: nodejs#48113
Refs: nodejs/security-wg#828
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@marco-ippolito @Ceres6
tools: add security-wg as dep updaters owner
249f6a7 
PR-URL: nodejs#48113
Refs: nodejs/security-wg#828
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@richardlau richardlau richardlau approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees
No one assigned
Labels
commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@marco-ippolito @nodejs-github-bot @Trott @lpinca @richardlau @RafaelGSS @RaisinTen