Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update nghttp2 to 1.53.0 #47997

Merged
merged 2 commits into from
May 18, 2023
Merged

deps: update nghttp2 to 1.53.0 #47997

merged 2 commits into from
May 18, 2023

Conversation

nodejs-github-bot
Copy link
Collaborator

This is an automated update of nghttp2 to 1.53.0.

@nodejs-github-bot nodejs-github-bot added the dependencies Pull requests that update a dependency file. label May 14, 2023
@nodejs-github-bot
Copy link
Collaborator Author

Review requested:

  • @nodejs/http2
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. labels May 14, 2023
@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label May 14, 2023
@RafaelGSS
Copy link
Member

why is it conflicting? @marco-ippolito

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 14, 2023
@marco-ippolito
Copy link
Member

marco-ippolito commented May 14, 2023 •
edited
Loading

why is it conflicting? @marco-ippolito

because of this #46636 which changed #define NGHTTP2_VERSION_NUM 0x013400 , anyways it does not build

@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/51797/

@github-actions github-actions bot mentioned this pull request May 15, 2023
Open
17 tasks
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/51814/

@marco-ippolito marco-ippolito added request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels May 15, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 15, 2023
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/51815/

@github-actions github-actions bot mentioned this pull request May 16, 2023
Open
19 tasks
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/51827/

This was referenced May 17, 2023
Open
Open
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/51863/

@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/51864/

@marco-ippolito marco-ippolito added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels May 18, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 18, 2023
@nodejs-github-bot nodejs-github-bot merged commit 3538e1b into main May 18, 2023
@nodejs-github-bot nodejs-github-bot deleted the actions/tools-update-nghttp2 branch May 18, 2023 13:59
@nodejs-github-bot
Copy link
Collaborator Author

Landed in 3538e1b

This was referenced May 19, 2023
Open
Open
Open
Open
fasenderos pushed a commit to fasenderos/node that referenced this pull request May 22, 2023
@nodejs-github-bot @fasenderos
deps: update nghttp2 to 1.53.0
a5008b7 
PR-URL: nodejs#47997
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
This was referenced May 23, 2023
Open
Open
Open
targos pushed a commit that referenced this pull request May 30, 2023
@nodejs-github-bot @targos
deps: update nghttp2 to 1.53.0
d3e3a91 
PR-URL: #47997
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@targos targos mentioned this pull request Jun 4, 2023
Merged
@danielleadams
Copy link
Member

This should be backported to v18.x - it breaks the build on the staging branch.

@danielleadams danielleadams added the backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. label Jul 5, 2023
richardlau pushed a commit to richardlau/node-1 that referenced this pull request Oct 11, 2023
@nodejs-github-bot @richardlau
deps: update nghttp2 to 1.53.0
985a204 
PR-URL: nodejs#47997
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@richardlau richardlau mentioned this pull request Oct 11, 2023
Closed
@richardlau richardlau added backport-open-v18.x Indicate that the PR has an open backport. and removed backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. labels Oct 11, 2023
@richardlau
Copy link
Member

Opened a backport PR for this and other nghttp2 versions to Node.js 18: #50151

richardlau pushed a commit that referenced this pull request Oct 12, 2023
@nodejs-github-bot @richardlau
deps: update nghttp2 to 1.53.0
300a902 
PR-URL: #47997
Backport-PR-URL: #50151
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@richardlau richardlau added backported-to-v18.x PRs backported to the v18.x-staging branch. and removed backport-open-v18.x Indicate that the PR has an open backport. labels Oct 12, 2023
@hermanbanken hermanbanken mentioned this pull request Mar 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees
No one assigned
Labels
backported-to-v18.x PRs backported to the v18.x-staging branch. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dependencies Pull requests that update a dependency file. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nodejs-github-bot @RafaelGSS @marco-ippolito @danielleadams @richardlau @lpinca