test_runner: fix ordering of test hooks #47931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
MoLow
reviewed
May 9, 2023
|
please amend the commit message from |
For tests with subtests the before hook was being run after the beforeEach hook, which is the opposite to test suites and expectations. Also, a function was being used to close over the after hooks, but at the point it was being run the after hooks were not yet set up. Fixes nodejs#47915
philnash
force-pushed
the
before-before-beforeeach
branch
from
f08f31f to
3ae2015
Compare
philnash
changed the title
|
I've updated the commit message. Thanks for the review. |
MoLow
approved these changes
May 10, 2023
MoLow
added
author ready
github-actions
bot
removed
the
request-ci
|
I can see that some of the Jenkins jobs are failing. Though I'm not sure why. Is there anything I can do to help this? |
that is not related to this PR, unfortunately there are some flaky tests |
Ah, fair enough. Thank you! |
cjihrig
reviewed
May 10, 2023
24 tasks
cjihrig
approved these changes
May 11, 2023
github-actions
bot
removed
the
request-ci
MoLow
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 24615bd |
|
Thanks for the contribution @philnash 🎉 |
|
Thanks for the help getting this in @MoLow! |
23 tasks
targos
pushed a commit
that referenced
this pull request
May 12, 2023
For tests with subtests the before hook was being run after the beforeEach hook, which is the opposite to test suites and expectations. Also, a function was being used to close over the after hooks, but at the point it was being run the after hooks were not yet set up. Fixes #47915 PR-URL: #47931 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced May 13, 2023
This was referenced May 16, 2023
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
For tests with subtests the before hook was being run after the beforeEach hook, which is the opposite to test suites and expectations. Also, a function was being used to close over the after hooks, but at the point it was being run the after hooks were not yet set up. Fixes #47915 PR-URL: #47931 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
For tests with subtests the before hook was being run after the beforeEach hook, which is the opposite to test suites and expectations. Also, a function was being used to close over the after hooks, but at the point it was being run the after hooks were not yet set up. Fixes nodejs#47915 PR-URL: nodejs#47931 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For tests with subtests the before hook was being run after the beforeEach hook, which is the opposite to test suites and expectations.
Also, a function was being used to close over the after hooks, but at the point it was being run the after hooks were not yet set up.
Fixes #47915