Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test,crypto: update WebCryptoAPI WPT #47921

Merged
merged 1 commit into from
May 10, 2023
Merged

test,crypto: update WebCryptoAPI WPT #47921

merged 1 commit into from
May 10, 2023

Conversation

panva
Copy link
Member

@panva panva commented May 8, 2023

Refs: #47864

@panva panva added crypto Issues and PRs related to the crypto subsystem. test Issues and PRs related to the tests. needs-ci PRs that need a full CI run. request-ci Add this label to start a Jenkins CI on a PR. webcrypto labels May 8, 2023
anonrig
anonrig approved these changes May 8, 2023
View reviewed changes
Copy link
Member

@anonrig anonrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice:

Watch the video

@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 8, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 8, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51699/

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label May 8, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 10, 2023
@nodejs-github-bot nodejs-github-bot merged commit ea8fd2d into nodejs:main May 10, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in ea8fd2d

targos pushed a commit that referenced this pull request May 12, 2023
@panva @targos
test,crypto: update WebCryptoAPI WPT
aa2c7e0 
PR-URL: #47921
Refs: #47864
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request May 15, 2023
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@panva @danielleadams
test,crypto: update WebCryptoAPI WPT
73e4112 
PR-URL: #47921
Refs: #47864
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@panva @MoLow
test,crypto: update WebCryptoAPI WPT
4bece05 
PR-URL: nodejs#47921
Refs: nodejs#47864
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. webcrypto
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@panva @nodejs-github-bot @jasnell @lpinca @anonrig