Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url: call ada::can_parse directly #47919

Merged
merged 1 commit into from
May 18, 2023
Merged

url: call ada::can_parse directly #47919

merged 1 commit into from
May 18, 2023

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented May 8, 2023

We're planning on improving the performance of ada::can_parse and added this function in 2.3.1 release. This would make things a lot easier and more readable for Node.js.

cc @KhafraDev @nodejs/url

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/url

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels May 8, 2023
@anonrig anonrig requested review from TimothyGu and KhafraDev May 8, 2023 15:44
lemire
lemire approved these changes May 8, 2023
View reviewed changes
Copy link
Member

@lemire lemire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This opens up future optimization opportunities.

@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label May 8, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 8, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51701/

@github-actions github-actions bot mentioned this pull request May 9, 2023
Open
29 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51713/

@anonrig
Copy link
Member Author

anonrig commented May 9, 2023

@nodejs/build I couldn't understand the root cause of the error in Test ASan build. Any ideas?

@github-actions github-actions bot mentioned this pull request May 10, 2023
Open
25 tasks
jasnell
jasnell approved these changes May 10, 2023
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but looks like there's an asan issue in ada::url that needs looking at.

@Trott
Copy link
Member

Trott commented May 10, 2023

LGTM but looks like there's an asan issue in ada::url that needs looking at.

Because the ASan output is massive and the relevant part can be hard to find, here's a link to the relevant part: https://github.com/nodejs/node/actions/runs/4929741771/jobs/8809762438?pr=47919#step:6:5394

Be patient while it loads. The relevant line starts with ==168106==ERROR:.

@Trott
Copy link
Member

Trott commented May 10, 2023

LGTM but looks like there's an asan issue in ada::url that needs looking at.

Because the ASan output is massive and the relevant part can be hard to find, here's a link to the relevant part: https://github.com/nodejs/node/actions/runs/4929741771/jobs/8809762438?pr=47919#step:6:5394

Be patient while it loads. The relevant line starts with ==168106==ERROR:.

Ugh, that link didn't work. You need to scroll back up to line 5393.

@anonrig
Copy link
Member Author

anonrig commented May 10, 2023

Because the ASan output is massive and the relevant part can be hard to find, here's a link to the relevant part: https://github.com/nodejs/node/actions/runs/4929741771/jobs/8809762438?pr=47919#step:6:5394

Be patient while it loads. The relevant line starts with ==168106==ERROR:.

@lemire do you have any idea about the root cause of this error?

lemire
lemire reviewed May 10, 2023
View reviewed changes
src/node_url.cc Outdated Show resolved Hide resolved
lemire
lemire reviewed May 10, 2023
View reviewed changes
src/node_url.cc Outdated Show resolved Hide resolved
@lemire
Copy link
Member

lemire commented May 10, 2023

@Trott I suspect it is not in ada that we have a memory error. See my comment above.

This was referenced May 11, 2023
Open
Open
Open
Open
Open
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label May 17, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 17, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51837/

@github-actions github-actions bot mentioned this pull request May 18, 2023
Open
20 tasks
RaisinTen
RaisinTen reviewed May 18, 2023
View reviewed changes
src/node_url.cc Outdated Show resolved Hide resolved
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label May 18, 2023
RaisinTen
RaisinTen approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@RaisinTen RaisinTen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 18, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51865/

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label May 18, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 18, 2023
@nodejs-github-bot nodejs-github-bot merged commit 8b6947f into main May 18, 2023
@nodejs-github-bot nodejs-github-bot deleted the ada-can-parse branch May 18, 2023 17:49
@nodejs-github-bot
Copy link
Collaborator

Landed in 8b6947f

This was referenced May 19, 2023
Open
Open
Open
Open
fasenderos pushed a commit to fasenderos/node that referenced this pull request May 22, 2023
@anonrig @fasenderos
url: call ada::can_parse directly
9bff5f4 
PR-URL: nodejs#47919
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@github-actions github-actions bot mentioned this pull request May 23, 2023
Open
22 tasks
targos pushed a commit that referenced this pull request May 30, 2023
@anonrig @targos
url: call ada::can_parse directly
ebb6536 
PR-URL: #47919
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@targos targos mentioned this pull request Jun 4, 2023
Merged
@danielleadams danielleadams added the backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. label Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemire lemire lemire approved these changes

@KhafraDev KhafraDev KhafraDev approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

@jasnell jasnell jasnell approved these changes

@TimothyGu TimothyGu Awaiting requested review from TimothyGu

Assignees
No one assigned
Labels
backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@anonrig @nodejs-github-bot @Trott @lemire @jasnell @RaisinTen @KhafraDev @danielleadams