Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vm,lib: refactor microtaskQueue assignment logic #47765

Closed
wants to merge 1 commit into from
Closed

vm,lib: refactor microtaskQueue assignment logic #47765

wants to merge 1 commit into from

Conversation

XadillaX
Copy link
Contributor

No description provided.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem. labels Apr 28, 2023
@XadillaX
vm,lib: refactor microtaskQueue assignment logic
c57c126 
Simplify the assignment of the `microtaskQueue` variable in the `vm`
module by replacing the conditional block with a more concise ternary
operator. This change improves code readability and maintainability.
@XadillaX XadillaX changed the title vm: remove an unnecessary microtaskMode condition vm,lib: refactor microtaskQueue assignment logic Apr 29, 2023
@XadillaX XadillaX requested a review from addaleax April 30, 2023 00:53
yorkie
yorkie reviewed Apr 30, 2023
View reviewed changes
Copy link
Contributor

@yorkie yorkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks easiler to read to me :)

@theanarkh theanarkh added the request-ci Add this label to start a Jenkins CI on a PR. label May 1, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 1, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51559/

This was referenced May 3, 2023
Open
Open
@XadillaX XadillaX added the request-ci Add this label to start a Jenkins CI on a PR. label May 7, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 7, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51690/

@XadillaX XadillaX removed the request for review from addaleax May 13, 2023 14:07
XadillaX added a commit that referenced this pull request May 13, 2023
@XadillaX
vm,lib: refactor microtaskQueue assignment logic
23e6b12 
Simplify the assignment of the `microtaskQueue` variable in the `vm`
module by replacing the conditional block with a more concise ternary
operator. This change improves code readability and maintainability.

PR-URL: #47765
Reviewed-By: theanarkh <theratliter@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@XadillaX
Copy link
Contributor Author

Landed in 23e6b12

@XadillaX XadillaX closed this May 13, 2023
targos pushed a commit that referenced this pull request May 14, 2023
@XadillaX @targos
vm,lib: refactor microtaskQueue assignment logic
931874c 
Simplify the assignment of the `microtaskQueue` variable in the `vm`
module by replacing the conditional block with a more concise ternary
operator. This change improves code readability and maintainability.

PR-URL: #47765
Reviewed-By: theanarkh <theratliter@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request May 15, 2023
@XadillaX @targos
vm,lib: refactor microtaskQueue assignment logic
e6685f9 
Simplify the assignment of the `microtaskQueue` variable in the `vm`
module by replacing the conditional block with a more concise ternary
operator. This change improves code readability and maintainability.

PR-URL: #47765
Reviewed-By: theanarkh <theratliter@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request May 15, 2023
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@XadillaX @danielleadams
vm,lib: refactor microtaskQueue assignment logic
1f2b5f6 
Simplify the assignment of the `microtaskQueue` variable in the `vm`
module by replacing the conditional block with a more concise ternary
operator. This change improves code readability and maintainability.

PR-URL: #47765
Reviewed-By: theanarkh <theratliter@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@XadillaX @MoLow
vm,lib: refactor microtaskQueue assignment logic
4b2aa3d 
Simplify the assignment of the `microtaskQueue` variable in the `vm`
module by replacing the conditional block with a more concise ternary
operator. This change improves code readability and maintainability.

PR-URL: nodejs#47765
Reviewed-By: theanarkh <theratliter@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yorkie yorkie yorkie left review comments

@lpinca lpinca lpinca approved these changes

@theanarkh theanarkh theanarkh approved these changes

@Mesteery Mesteery Mesteery approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@XadillaX @nodejs-github-bot @lpinca @yorkie @theanarkh @Mesteery