build: use pathlib for paths #47581
Merged
build: use pathlib for paths #47581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
VoltrexKeyva
added
the
python
anonrig
reviewed
Apr 17, 2023
VoltrexKeyva
force-pushed
the
use-pathlib
branch
from
6d9d20c
to
495b1fc
Compare
anonrig
approved these changes
Apr 17, 2023
|
@nodejs/python |
cclauss
approved these changes
Apr 17, 2023
VoltrexKeyva
force-pushed
the
use-pathlib
branch
from
495b1fc
to
aa2fe83
Compare
Trott
added
request-ci
github-actions
bot
removed
the
request-ci
VoltrexKeyva
force-pushed
the
use-pathlib
branch
from
aa2fe83
to
fbc3909
Compare
VoltrexKeyva
force-pushed
the
use-pathlib
branch
from
fbc3909
to
289a07d
Compare
github-actions
bot
removed
the
request-ci
VoltrexKeyva
force-pushed
the
use-pathlib
branch
from
289a07d
to
66e508a
Compare
github-actions
bot
removed
the
request-ci
|
@VoltrexKeyva Can you please create a pull request for all the non-pathlib changes so we can see if we can get that one to pass the tests and land first? |
This was referenced Apr 22, 2023
This was referenced Apr 24, 2023
github-actions
bot
removed
the
request-ci
|
@cclauss fortunately there are no failures, should we land this now? |
|
Nice! Two approvals are above. |
VoltrexKeyva
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/47581 ✔ Done loading data for nodejs/node/pull/47581 ----------------------------------- PR info ------------------------------------ Title build: use pathlib for paths (#47581) Author Mohammed Keyvanzadeh (@VoltrexKeyva) Branch VoltrexKeyva:use-pathlib -> nodejs:main Labels build, python, author ready, needs-ci Commits 1 - build: use pathlib for paths Committers 1 - Mohammed Keyvanzadeh PR-URL: https://github.com/nodejs/node/pull/47581 Reviewed-By: Yagiz Nizipli Reviewed-By: Christian Clauss ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47581 Reviewed-By: Yagiz Nizipli Reviewed-By: Christian Clauss -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - build: use pathlib for paths ℹ This PR was created on Sun, 16 Apr 2023 14:21:56 GMT ✔ Approvals: 2 ✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/47581#pullrequestreview-1388073872 ✔ - Christian Clauss (@cclauss): https://github.com/nodejs/node/pull/47581#pullrequestreview-1388196158 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-05-02T14:23:08Z: https://ci.nodejs.org/job/node-test-pull-request/51578/ - Querying data for job/node-test-pull-request/51578/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4863726456 |
|
@cclauss this'll need an approval again, as new changes invalidates the older approvals. |
cclauss
approved these changes
May 2, 2023
VoltrexKeyva
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in d2156f1 |
|
Rock & Roll... Thanks for doing this! |
33 tasks
targos
pushed a commit
that referenced
this pull request
May 3, 2023
Use Python's `pathlib` library for paths and related operations instead of `os.path`. Refs: #47323 (comment) #47323 (comment) PR-URL: #47581 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Christian Clauss <cclauss@me.com>
targos
pushed a commit
that referenced
this pull request
May 3, 2023
Use Python's `pathlib` library for paths and related operations instead of `os.path`. Refs: #47323 (comment) #47323 (comment) PR-URL: #47581 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Christian Clauss <cclauss@me.com>
This was referenced May 4, 2023
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
Use Python's `pathlib` library for paths and related operations instead of `os.path`. Refs: #47323 (comment) #47323 (comment) PR-URL: #47581 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Christian Clauss <cclauss@me.com>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
Use Python's `pathlib` library for paths and related operations instead of `os.path`. Refs: nodejs#47323 (comment) nodejs#47323 (comment) PR-URL: nodejs#47581 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Christian Clauss <cclauss@me.com>
srl295
reviewed
Oct 1, 2024
| @@ -1766,39 +1768,39 @@ def icu_download(path): | |||
| icu_config['variables']['icu_full_canned'] = 1 | |||
| # --with-icu-source processing | |||
| # now, check that they didn't pass --with-icu-source=deps/icu | |||
| elif with_icu_source and os.path.abspath(icu_full_path) == os.path.abspath(with_icu_source): | |||
| elif with_icu_source and Path(icu_full_path).resolve() == Path(with_icu_source).resolve(): | |||
There was a problem hiding this comment.
Ouch! icu_full_path can actually be a URL here, and so this change breaks Windows downloading completely. Not good..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Python's
pathliblibrary for paths and related operations instead ofos.path.Refs: #47323 (comment) #47323 (comment)