Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/child_process: call postSend on error #4752

Closed
wants to merge 1 commit into from
Closed

internal/child_process: call postSend on error #4752

wants to merge 1 commit into from

Commits on Jan 22, 2016

  1. internal/child_process: call postSend on error 

    Call `obj.postSend` in error case of `process.send()`. The
`net.Socket`'s handle should not be leaked.

Note that there are two callbacks invoked on handles
when they are sent to the child process over IPC pipes.
These callbacks are specified by `handleConversion` object, and
during send two of them are invoked:

  * `send`
  * `postSend`

Now for `net.Socket` in particular, `postSend` performs clean up by
closing the actual uv handle. However this clean up will not happen in
one of the branches. This pull request aims to fix this.
    @indutny
    indutny committed Jan 22, 2016
    Configuration menu
    Copy the full SHA
    994071b View commit details
    Browse the repository at this point in the history