Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky test-watch-mode-inspect #47403

Merged
merged 1 commit into from
Apr 4, 2023
Merged

test: fix flaky test-watch-mode-inspect #47403

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions test/sequential/test-watch-mode-inspect.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,10 @@ describe('watch mode - inspect', () => {

// There should be a process per restart and one per parent process.
// Message about Debugger should appear once per restart.
// On some systems restart can happen multiple times.
const restarts = stdout.filter((line) => line === 'safe to debug now').length;
assert.strictEqual(stderr.match(/Debugger listening on ws:\/\//g).length, restarts);
assert.strictEqual(new Set(pids).size, restarts + 1);
assert.ok(stderr.match(/Debugger listening on ws:\/\//g).length >= restarts);
MoLow marked this conversation as resolved.
Show resolved Hide resolved
assert.ok(new Set(pids).size >= restarts + 1);
});

it('should prevent attaching debugger with SIGUSR1 to outer process', { skip: common.isWindows }, async () => {
Expand Down