Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quic: add additional utilities for quic (part 2) #47289

Closed
wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Mar 29, 2023

The second PR incrementally adding QUIC impl details. Again, the idea is to space these out over multiple PRS to make it easier to review instead of the big monolith that #44325 is. Easiest to review each commit individually.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp

@jasnell jasnell added quic Issues and PRs related to the QUIC implementation / HTTP/3. dont-land-on-v14.x dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. labels Mar 29, 2023
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Mar 29, 2023
@targos

This comment was marked as resolved.

@targos

This comment was marked as resolved.

@jasnell

This comment was marked as resolved.

src/quic/sessionticket.cc Outdated Show resolved Hide resolved
src/quic/sessionticket.cc Outdated Show resolved Hide resolved
src/quic/sessionticket.cc Outdated Show resolved Hide resolved
src/quic/sessionticket.cc Outdated Show resolved Hide resolved
src/quic/sessionticket.h Show resolved Hide resolved
src/quic/sessionticket.h Show resolved Hide resolved
src/quic/tokens.cc Outdated Show resolved Hide resolved
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 29, 2023

@jasnell jasnell added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Mar 29, 2023
src/quic/tokens.cc Show resolved Hide resolved
src/quic/tokens.cc Outdated Show resolved Hide resolved
@jasnell jasnell requested a review from tniessen March 30, 2023 17:26
src/quic/sessionticket.cc Outdated Show resolved Hide resolved
* add TokenSecret, StatelessResetToken, RetryToken, and RegularToken
* add SessionTicket implementation
@jasnell
Copy link
Member Author

jasnell commented Mar 31, 2023

Landed in d65ae9f

@jasnell jasnell closed this Mar 31, 2023
jasnell added a commit that referenced this pull request Mar 31, 2023
* add TokenSecret, StatelessResetToken, RetryToken, and RegularToken
* add SessionTicket implementation

PR-URL: #47289
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. lib / src Issues and PRs related to general changes in the lib or src directory. quic Issues and PRs related to the QUIC implementation / HTTP/3.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants