test_runner: accept \x1b as a escape symbol #47050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
dont-land-on-v14.x
needs-ci
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
debadree25
added
the
author ready
This was referenced Mar 13, 2023
MoLow
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/47050 ✔ Done loading data for nodejs/node/pull/47050 ----------------------------------- PR info ------------------------------------ Title test_runner: accept \x1b as a escape symbol (#47050) Author Debadree Chatterjee (@debadree25) Branch debadree25:ft/tap-lexer-ansi-escape -> nodejs:main Labels author ready, needs-ci, dont-land-on-v14.x, test_runner Commits 2 - test_runner: accept \x1b as a escape symbol - fixup! space Committers 1 - Debadree Chatterjee PR-URL: https://github.com/nodejs/node/pull/47050 Fixes: https://github.com/nodejs/node/issues/46959 Reviewed-By: Moshe Atlow ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47050 Fixes: https://github.com/nodejs/node/issues/46959 Reviewed-By: Moshe Atlow -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 12 Mar 2023 11:01:47 GMT ✔ Approvals: 1 ✔ - Moshe Atlow (@MoLow): https://github.com/nodejs/node/pull/47050#pullrequestreview-1336012293 ✘ This PR needs to wait 86 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-03-12T14:21:21Z: https://ci.nodejs.org/job/node-test-pull-request/50335/ - Querying data for job/node-test-pull-request/50335/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4430846114 |
22 tasks
|
would need another review to land |
lpinca
approved these changes
Mar 16, 2023
debadree25
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/47050 ✔ Done loading data for nodejs/node/pull/47050 ----------------------------------- PR info ------------------------------------ Title test_runner: accept \x1b as a escape symbol (#47050) Author Debadree Chatterjee (@debadree25) Branch debadree25:ft/tap-lexer-ansi-escape -> nodejs:main Labels author ready, needs-ci, dont-land-on-v14.x, test_runner Commits 2 - test_runner: accept \x1b as a escape symbol - fixup! space Committers 1 - Debadree Chatterjee PR-URL: https://github.com/nodejs/node/pull/47050 Fixes: https://github.com/nodejs/node/issues/46959 Reviewed-By: Moshe Atlow Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47050 Fixes: https://github.com/nodejs/node/issues/46959 Reviewed-By: Moshe Atlow Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 12 Mar 2023 11:01:47 GMT ✔ Approvals: 2 ✔ - Moshe Atlow (@MoLow): https://github.com/nodejs/node/pull/47050#pullrequestreview-1336012293 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/47050#pullrequestreview-1344628705 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-03-15T20:55:54Z: https://ci.nodejs.org/job/node-test-pull-request/50335/ - Querying data for job/node-test-pull-request/50335/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 47050 From https://github.com/nodejs/node * branch refs/pull/47050/merge -> FETCH_HEAD ✔ Fetched commits as 8713c83462df..52c773d3e481 -------------------------------------------------------------------------------- [main 3955686063] test_runner: accept \x1b as a escape symbol Author: Debadree Chatterjee Date: Sun Mar 12 16:28:02 2023 +0530 2 files changed, 13 insertions(+), 1 deletion(-) [main 9b2bdf9330] fixup! space Author: Debadree Chatterjee Date: Sun Mar 12 16:28:34 2023 +0530 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)https://github.com/nodejs/node/actions/runs/4441310390 |
MoLow
added
commit-queue
MoLow
added
the
commit-queue-squash
nodejs-github-bot
removed
the
commit-queue
|
Landed in d51541b |
This was referenced Mar 17, 2023
This was referenced Apr 3, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that TAPLexer was throwing an error on the ANSI code
\x1bhence added the same as a escape symbolFixes: #46959