permission: add path separator to loader check #47030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
github-actions
bot
added
request-ci-failed
Failed to start CI- Validating Jenkins credentials ✘ Jenkins credentials invalidhttps://github.com/nodejs/node/actions/runs/4376751803 |
aduh95
reviewed
Mar 9, 2023
aduh95
reviewed
Mar 9, 2023
RafaelGSS
force-pushed
the
fix/permission-model-package-json
branch
from
05b939b to
f01ff0e
Compare
aduh95
added
request-ci
github-actions
bot
removed
the
request-ci
cjihrig
reviewed
Mar 9, 2023
RafaelGSS
force-pushed
the
fix/permission-model-package-json
branch
from
f01ff0e to
0c16b39
Compare
22 tasks
RafaelGSS
force-pushed
the
fix/permission-model-package-json
branch
from
0c16b39 to
ed41d3d
Compare
GeoffreyBooth
approved these changes
Mar 10, 2023
RafaelGSS
force-pushed
the
fix/permission-model-package-json
branch
from
ed41d3d to
ceca668
Compare
benjamingr
approved these changes
Mar 10, 2023
github-actions
bot
removed
the
request-ci
22 tasks
This was referenced Mar 12, 2023
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
RafaelGSS
force-pushed
the
fix/permission-model-package-json
branch
from
ceca668 to
a2f399b
Compare
github-actions
bot
removed
the
request-ci
22 tasks
RafaelGSS
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/47030 ✔ Done loading data for nodejs/node/pull/47030 ----------------------------------- PR info ------------------------------------ Title permission: add path separator to loader check (#47030) Author Rafael Gonzaga (@RafaelGSS) Branch RafaelGSS:fix/permission-model-package-json -> nodejs:main Labels needs-ci Commits 1 - permission: add path separator to loader check Committers 1 - RafaelGSS PR-URL: https://github.com/nodejs/node/pull/47030 Reviewed-By: Geoffrey Booth Reviewed-By: Benjamin Gruenbaum ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47030 Reviewed-By: Geoffrey Booth Reviewed-By: Benjamin Gruenbaum -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - permission: add path separator to loader check ℹ This PR was created on Thu, 09 Mar 2023 16:26:17 GMT ✔ Approvals: 2 ✔ - Geoffrey Booth (@GeoffreyBooth) (TSC): https://github.com/nodejs/node/pull/47030#pullrequestreview-1334118656 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/47030#pullrequestreview-1335554726 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-03-14T23:34:49Z: https://ci.nodejs.org/job/node-test-pull-request/50383/ - Querying data for job/node-test-pull-request/50383/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4426823538 |
marco-ippolito
approved these changes
Mar 15, 2023
RafaelGSS
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 1726da9 |
22 tasks
RafaelGSS
added
backport-blocked-v16.x
backport-blocked-v18.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no package.json is found the loader walks upwards until the root path
/. When checking the root, thecheckPathis empty ('') and an attempt to read/package.jsonis made. However, reading from/isn't allowed (considering --allow-fs-read=/Users/ was passed).This commit fixes this behavior.