Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: slim down stream_base-inl.h #46972

Merged
merged 4 commits into from
Apr 11, 2023
Merged

src: slim down stream_base-inl.h #46972

merged 4 commits into from
Apr 11, 2023

Conversation

lilsweetcaligula
Copy link
Contributor

@lilsweetcaligula lilsweetcaligula commented Mar 6, 2023 •
edited
Loading

De-inline and move big functions from stream_base-inl.h to reduce the binary size by 4 bytes in 9/10 compilations.

Other method definitions were tested (notably StreamResource::PushStreamListener), however I empirically verified (via compiling multiple times) that moving those increased the binary size, hence I left them alone.

Non-functional change.

Refs: #43712

P.S. Special thanks to @kvakil for posting the SQLite3 database which I in part relied upon to make the decisions.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Mar 6, 2023
@lilsweetcaligula lilsweetcaligula marked this pull request as ready for review March 6, 2023 12:31
@lilsweetcaligula
Copy link
Contributor Author

@addaleax Hi! After the PR was approved, I noticed that the CI failed due to a linter error that snuck in - should I re-request a review after I address the linter error? Thank you.

@addaleax
Copy link
Member

addaleax commented Mar 8, 2023

@lilsweetcaligula It will be a tad easier to get this PR merged if the most recent changes are approved after the linter error is fixed, but I if that’s all that changed, I think you’re fine either way. (We’ll still want to run CI on that, in any case, so somebody will need take a look regardless.)

@debadree25 debadree25 added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 10, 2023
@debadree25 debadree25 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Apr 10, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 10, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51115/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51121/

@Trott
Copy link
Member

Trott commented Apr 10, 2023

@nodejs/actions It seems like GitHub Actions did not start for this PR. Is there a way to start them?

@targos targos marked this pull request as draft April 10, 2023 18:13
@targos targos marked this pull request as ready for review April 10, 2023 18:13
@targos
Copy link
Member

targos commented Apr 10, 2023

Convert to draft and mark ready for review like I just did.

@debadree25 debadree25 added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 11, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 11, 2023
@nodejs-github-bot nodejs-github-bot merged commit 97d3912 into nodejs:main Apr 11, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 97d3912

This was referenced Apr 12, 2023
Open
Open
targos pushed a commit that referenced this pull request May 2, 2023
@lilsweetcaligula @targos
src: slim down stream_base-inl.h
adc1601 
PR-URL: #46972
Refs: #43712
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
@targos targos mentioned this pull request May 2, 2023
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@lilsweetcaligula @danielleadams
src: slim down stream_base-inl.h
c19bdae 
PR-URL: #46972
Refs: #43712
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@lilsweetcaligula @MoLow
src: slim down stream_base-inl.h
e88e249 
PR-URL: nodejs#46972
Refs: nodejs#43712
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
@jdiaz-dev
Copy link
Contributor

Hi @lilsweetcaligula
I am new trying to contribute in Node.js codebase
I Found a function that is executed (trigger_scope), but it never was defined and inplemented
Maybe do you may explain me how to work this kind of function?
code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@debadree25 debadree25 debadree25 approved these changes

@juanarbol juanarbol juanarbol approved these changes

@addaleax addaleax addaleax approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@lilsweetcaligula @addaleax @nodejs-github-bot @Trott @targos @jdiaz-dev @bnoordhuis @juanarbol @debadree25