Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: simplify test-tls-ecdh-auto #46911

Merged
merged 1 commit into from
Mar 5, 2023
Merged

test: simplify test-tls-ecdh-auto #46911

merged 1 commit into from
Mar 5, 2023

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented Mar 2, 2023

Avoid the process 'exit' event handler and use execFile instead of manual stream operations.

Refs: #46751

@tniessen
test: simplify test-tls-ecdh-auto
818d71b 
Avoid the process 'exit' event handler and use execFile instead of
manual stream operations.

Refs: nodejs#46751
@tniessen tniessen added tls Issues and PRs related to the tls subsystem. test Issues and PRs related to the tests. labels Mar 2, 2023
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Mar 2, 2023
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 2, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 2, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50163/

@tniessen tniessen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 2, 2023
@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 5, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 5, 2023
@nodejs-github-bot nodejs-github-bot merged commit 06c660b into nodejs:main Mar 5, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 06c660b

targos pushed a commit that referenced this pull request Mar 13, 2023
@tniessen @targos
test: simplify test-tls-ecdh-auto
38c5b8b 
Avoid the process 'exit' event handler and use execFile instead of
manual stream operations.

Refs: #46751
PR-URL: #46911
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
targos pushed a commit that referenced this pull request Mar 14, 2023
@tniessen @targos
test: simplify test-tls-ecdh-auto
21153f1 
Avoid the process 'exit' event handler and use execFile instead of
manual stream operations.

Refs: #46751
PR-URL: #46911
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
@targos targos mentioned this pull request Mar 14, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@tniessen @danielleadams
test: simplify test-tls-ecdh-auto
3399195 
Avoid the process 'exit' event handler and use execFile instead of
manual stream operations.

Refs: #46751
PR-URL: #46911
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
@danielleadams danielleadams mentioned this pull request Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panva panva panva approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tniessen @nodejs-github-bot @panva @lpinca