Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debugger: Add set context line number command #46812

Merged
merged 6 commits into from
Mar 12, 2023
Merged

debugger: Add set context line number command #46812

merged 6 commits into from
Mar 12, 2023

Conversation

Dailyscat
Copy link
Contributor

related: #41788

@nodejs-github-bot nodejs-github-bot added debugger Issues and PRs related to the debugger subsystem. needs-ci PRs that need a full CI run. labels Feb 24, 2023
@Dailyscat Dailyscat force-pushed the add_setContextLineNumber_command branch from 8440c77 to 9fff60e Compare February 24, 2023 10:18
@cola119
Copy link
Member

cola119 commented Feb 24, 2023

@Dailyscat Great work! Changes look fine to me but can you do the chores before review?

  1. Can you update the commit message to conform to the guideline? The subsystem in this change is debugger, so debugger: add a command to set which lines to check for context is a good message.
  2. Can you run the linter make lint-js-fix?

@Dailyscat Dailyscat force-pushed the add_setContextLineNumber_command branch from 9fff60e to 4043dd4 Compare February 24, 2023 15:58
@Dailyscat Dailyscat force-pushed the add_setContextLineNumber_command branch 2 times, most recently from a5f311b to 6542213 Compare February 24, 2023 16:09
@Dailyscat
Copy link
Contributor Author

@Dailyscat Great work! Changes look fine to me but can you do the chores before review?

  1. Can you update the commit message to conform to the guideline? The subsystem in this change is debugger, so debugger: add a command to set which lines to check for context is a good message.
  2. Can you run the linter make lint-js-fix?

Oh I missed that part, fixed it, thanks!

@Dailyscat Dailyscat changed the title repl: Add set context line number command debugger: Add set context line number command Feb 25, 2023
@cola119 cola119 added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 26, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 26, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50042/

@github-actions github-actions bot mentioned this pull request Feb 28, 2023
Open
16 tasks
@Dailyscat Dailyscat force-pushed the add_setContextLineNumber_command branch from 6542213 to 730ad86 Compare February 28, 2023 06:43
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50086/

@github-actions github-actions bot mentioned this pull request Mar 1, 2023
Open
15 tasks
cola119
cola119 reviewed Mar 1, 2023
View reviewed changes
lib/internal/debugger/inspect_repl.js Show resolved Hide resolved
lib/internal/debugger/inspect_repl.js Outdated Show resolved Hide resolved
test/fixtures/debugger/twenty-lines.js Outdated Show resolved Hide resolved
test/sequential/test-debugger-set-context-line-number.mjs Outdated Show resolved Hide resolved
@github-actions github-actions bot mentioned this pull request Mar 2, 2023
Open
15 tasks
@Dailyscat
Copy link
Contributor Author

@cola119 san I applied a review. please check it!

@github-actions github-actions bot mentioned this pull request Mar 3, 2023
Open
18 tasks
@cola119 cola119 added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 3, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 3, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50180/

@cola119 cola119 added request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Mar 7, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 7, 2023
This was referenced Mar 8, 2023
Open
Open
@cola119 cola119 added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 9, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 9, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50284/

@github-actions github-actions bot mentioned this pull request Mar 10, 2023
Open
22 tasks
@cola119 cola119 added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 10, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 10, 2023
@github-actions github-actions bot mentioned this pull request Mar 11, 2023
Open
22 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50320/

@github-actions github-actions bot mentioned this pull request Mar 12, 2023
Open
20 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50325/

@cola119 cola119 added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 12, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 12, 2023
@nodejs-github-bot nodejs-github-bot merged commit 7f2ab4e into nodejs:main Mar 12, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 7f2ab4e

@github-actions github-actions bot mentioned this pull request Mar 13, 2023
Open
20 tasks
targos pushed a commit that referenced this pull request Mar 13, 2023
@Dailyscat @targos
debugger: add a command to set which lines to check for context
227629e 
PR-URL: #46812
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
@github-actions github-actions bot mentioned this pull request Mar 14, 2023
Open
24 tasks
targos pushed a commit that referenced this pull request Mar 14, 2023
@Dailyscat @targos
debugger: add a command to set which lines to check for context
afbd818 
PR-URL: #46812
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
@targos targos mentioned this pull request Mar 14, 2023
Merged
This was referenced Mar 15, 2023
Open
Open
Open
@cola119 cola119 mentioned this pull request Mar 26, 2023
Closed
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@Dailyscat @danielleadams
debugger: add a command to set which lines to check for context
51253ba 
PR-URL: #46812
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
@danielleadams danielleadams mentioned this pull request Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cola119 cola119 cola119 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. debugger Issues and PRs related to the debugger subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dailyscat @cola119 @nodejs-github-bot