doc: clarify semver-minor notable changes approach #46592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarifies the current approach taken by releasers when crafting notable changes for releases. This approach is also in line with the implementation of the `git node release --prepare` tooling.
|
Review requested:
|
richardlau
reviewed
Feb 10, 2023
richardlau
approved these changes
Feb 10, 2023
RafaelGSS
approved these changes
Feb 10, 2023
jasnell
approved these changes
Feb 10, 2023
targos
approved these changes
Feb 10, 2023
lpinca
approved these changes
Feb 10, 2023
Trott
approved these changes
Feb 11, 2023
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 79a92cd |
targos
pushed a commit
that referenced
this pull request
Mar 13, 2023
Clarifies the current approach taken by releasers when crafting notable changes for releases. This approach is also in line with the implementation of the `git node release --prepare` tooling. PR-URL: #46592 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
Clarifies the current approach taken by releasers when crafting notable changes for releases. This approach is also in line with the implementation of the `git node release --prepare` tooling. PR-URL: #46592 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarifies the current approach taken by releasers when crafting notable changes for releases. This approach is also in line with the implementation of the
git node release --preparetooling.This is a clarification of releasers existing order of operations, and as it is implemented by our release automation in nodejs/node-core-utils/blob/main/lib/prepare_release.js.
cc: @nodejs/releasers