doc: remove unused functions from example of streamConsumers.text
#46581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
json, blob, and buffer are imported, but these functions are not used for example of `streamConsumers.text`.
RaisinTen
approved these changes
Feb 9, 2023
cjihrig
approved these changes
Feb 9, 2023
deokjinkim
added
author ready
lpinca
approved these changes
Feb 9, 2023
|
Fast-track has been requested by @lpinca. Please 👍 to approve. |
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/46581 ✔ Done loading data for nodejs/node/pull/46581 ----------------------------------- PR info ------------------------------------ Title doc: remove unused functions from example of `streamConsumers.text` (#46581) Author Deokjin Kim (@deokjinkim) Branch deokjinkim:230209_doc_remove_unused_function -> nodejs:main Labels doc, fast-track, author ready Commits 1 - doc: remove unused functions from example of `streamConsumers.text` Committers 1 - Deokjin Kim PR-URL: https://github.com/nodejs/node/pull/46581 Reviewed-By: Darshan Sen Reviewed-By: Colin Ihrig Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/46581 Reviewed-By: Darshan Sen Reviewed-By: Colin Ihrig Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 09 Feb 2023 04:16:13 GMT ✔ Approvals: 3 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/46581#pullrequestreview-1290632923 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/46581#pullrequestreview-1290746607 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/46581#pullrequestreview-1291890386 ℹ This PR is being fast-tracked ✖ The fast-track request requires at least one collaborator's approval (👍). ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4137918133 |
deokjinkim
removed
the
commit-queue-failed
jasnell
approved these changes
Feb 11, 2023
deokjinkim
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in ecd385e |
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2023
json, blob, and buffer are imported, but these functions are not used for example of `streamConsumers.text`. PR-URL: #46581 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Feb 20, 2023
json, blob, and buffer are imported, but these functions are not used for example of `streamConsumers.text`. PR-URL: #46581 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
json, blob, and buffer are imported, but these functions are not used for example of `streamConsumers.text`. PR-URL: #46581 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
json, blob, and buffer are imported, but these functions are not used for example of
streamConsumers.text.