Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: fix macro name in update-undici #46217

Merged

Conversation

almeidx
Copy link
Contributor

@almeidx almeidx commented Jan 15, 2023

The tools/update-undici.sh script was using the same macro name as tools/update-acorn.sh

echo "#ifndef SRC_ACORN_VERSION_H_" >> "$FILE_PATH"
echo "#define SRC_ACORN_VERSION_H_" >> "$FILE_PATH"
echo "#define ACORN_VERSION \"$ACORN_VERSION\"" >> "$FILE_PATH"
echo "#endif // SRC_ACORN_VERSION_H_" >> "$FILE_PATH"

The generated file, however, has the correct macro name

#ifndef SRC_UNDICI_VERSION_H_
#define SRC_UNDICI_VERSION_H_
#define UNDICI_VERSION "5.14.0"
#endif // SRC_UNDICI_VERSION_H_

This seems to be an oversight from #45621

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jan 15, 2023
@debadree25
Copy link
Member

debadree25 commented Jan 15, 2023

Yes it does seem so
so sorry it missed me! Requesting approval from the maintainers, the code is lgtm

@lpinca lpinca added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 15, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @lpinca. Please 👍 to approve.

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 15, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 15, 2023
@nodejs-github-bot nodejs-github-bot merged commit f8b80a6 into nodejs:main Jan 15, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in f8b80a6

@almeidx almeidx deleted the tools/fix-update-undici-define branch January 15, 2023 14:47
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Jan 17, 2023
PR-URL: nodejs#46217
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Jan 20, 2023
PR-URL: #46217
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jan 20, 2023
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
PR-URL: #46217
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@juanarbol juanarbol mentioned this pull request Jan 28, 2023
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
PR-URL: #46217
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants