Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test to once() in event lib #46126

Conversation

jdiaz-dev
Copy link
Contributor

This test verify if eventEmmiter param is right in once method

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jan 7, 2023
Copy link
Member

@panva panva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the first commit message. It should not end with punctuation.

test/parallel/test-events-once.js Outdated Show resolved Hide resolved
@Trott
Copy link
Member

Trott commented Jan 7, 2023

Please update the first commit message. It should not end with punctuation.

While you're at, make the first word imperative mood. Maybe this?: test: add test to once() method in the event lib

@jdiaz-dev
Copy link
Contributor Author

I done changes according @panva and @Trott suggestions

This test verify if eventEmmiter param is right
@Trott Trott force-pushed the jonathanDiaz/adding-test-to-event-lib branch from 7e5e9fc to 187b5a3 Compare January 7, 2023 23:18
@panva panva changed the title test: adding test to once method of the event lib. test: add test to once() in event lib Jan 8, 2023
@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 8, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 8, 2023
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 8, 2023
@panva
Copy link
Member

panva commented Jan 8, 2023

@jdiaz-dev thank you for your first contribution. Barring any objections from other collaborators your PR will automatically land on the main branch after it's been open for 48 hours.

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 9, 2023
@nodejs-github-bot nodejs-github-bot merged commit 702303d into nodejs:main Jan 9, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 702303d

RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Jan 17, 2023
This test verify if eventEmmiter param is right

PR-URL: nodejs#46126
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Jan 20, 2023
This test verify if eventEmmiter param is right

PR-URL: #46126
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jan 20, 2023
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
This test verify if eventEmmiter param is right

PR-URL: #46126
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
@juanarbol juanarbol mentioned this pull request Jan 28, 2023
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
This test verify if eventEmmiter param is right

PR-URL: #46126
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants