Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add text around collaborative expectations #46121

Closed
wants to merge 6 commits into from
Closed

doc: add text around collaborative expectations #46121

wants to merge 6 commits into from

Conversation

mhdawson
Copy link
Member

@mhdawson mhdawson commented Jan 6, 2023

  • add text discussed by the TSC

Signed-off-by: Michael Dawson mdawson@devrus.com

@mhdawson
doc: add text around collaborative expectations
d008b7d 
- add text discussed by the TSC

Signed-off-by: Michael Dawson <mdawson@devrus.com>
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 6, 2023
mscdex
mscdex reviewed Jan 6, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
Trott
Trott reviewed Jan 6, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
Trott
Trott reviewed Jan 6, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@bnoordhuis
Copy link
Member

Did something prompt this? The blurb has a strong "water is wet, news at 11" vibe and the README is already interminably long...

Aside: I'd be in favor of moving out the collaborators/triagers/etc. lists.

RaisinTen
RaisinTen reviewed Jan 9, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@mhdawson @Trott
incorporate suggestions
51e0afd 
Co-authored-by: Rich Trott <rtrott@gmail.com>
aduh95
aduh95 reviewed Jan 9, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
aduh95
aduh95 reviewed Jan 9, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
mhdawson and others added 4 commits January 9, 2023 12:30
@mhdawson @aduh95
Update README.md
66a777f 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@mhdawson @aduh95
Update README.md
4202118 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@mhdawson @Trott
incorporate suggestions
cc7fc16 
Co-authored-by: Rich Trott <rtrott@gmail.com>
@mhdawson
incorporate suggested changes
febcd9e
@mhdawson
Copy link
Member Author

mhdawson commented Jan 9, 2023

@Trott I've incorporate all of your suggested changes.

ChALkeR
ChALkeR approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@ChALkeR ChALkeR left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(Would expect it below code of conduct, but that's not very signiciant.)

@mhdawson
Copy link
Member Author

I think the open questions have been discussed/answered. I meant to tag the TSC at begining with @nodejs/tsc which I'm doing now so that we get more TSC review before it lands. @nodejs/tsc.

mcollina
mcollina approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mhdawson
Copy link
Member Author

Ok going to go ahead and land.

@mhdawson
Copy link
Member Author

Landed in c62a860

@mhdawson mhdawson closed this Jan 17, 2023
mhdawson added a commit that referenced this pull request Jan 17, 2023
@mhdawson
doc: add text around collaborative expectations
c62a860 
- add text discussed by the TSC

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #46121
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Joe Sepi <sepi@joesepi.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Jan 17, 2023
@mhdawson @RafaelGSS
doc: add text around collaborative expectations
5e01bb9 
- add text discussed by the TSC

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: nodejs#46121
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Joe Sepi <sepi@joesepi.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
RafaelGSS pushed a commit that referenced this pull request Jan 20, 2023
@mhdawson @RafaelGSS
doc: add text around collaborative expectations
90924ce 
- add text discussed by the TSC

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #46121
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Joe Sepi <sepi@joesepi.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jan 20, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
@mhdawson @juanarbol
doc: add text around collaborative expectations
af04a4b 
- add text discussed by the TSC

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #46121
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Joe Sepi <sepi@joesepi.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
@juanarbol juanarbol mentioned this pull request Jan 28, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
@mhdawson @juanarbol
doc: add text around collaborative expectations
5294371 
- add text discussed by the TSC

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #46121
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Joe Sepi <sepi@joesepi.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott left review comments

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes

@mscdex mscdex mscdex left review comments

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@aduh95 aduh95 aduh95 approved these changes

@legendecas legendecas legendecas approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@mcollina mcollina mcollina approved these changes

@ChALkeR ChALkeR ChALkeR approved these changes

@joesepi joesepi joesepi approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

@ronag ronag ronag approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.