[v18.x backport] fs: fix nonNativeWatcher leak of StatWatchers #46031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
fs
mscdex
reviewed
Dec 31, 2022
|
|
||
| const watcher = fs.watch(testDirectory, { recursive: true }); | ||
| let watcherClosed = false; | ||
| watcher.on('change', common.mustCallAtLeast(function(event, filename) { |
There was a problem hiding this comment.
Suggested change
| watcher.on('change', common.mustCallAtLeast(function(event, filename) { | |
| watcher.on('change', common.mustCallAtLeast((event, filename) => { |
mscdex
reviewed
Dec 31, 2022
| const watcher = fs.watch(testDirectory, { recursive: true }); | ||
| let watcherClosed = false; | ||
| watcher.on('change', common.mustCallAtLeast(function(event, filename) { | ||
| // Libuv inconsistenly emits a rename event for the file we are watching |
There was a problem hiding this comment.
Suggested change
| // Libuv inconsistenly emits a rename event for the file we are watching | |
| // Libuv inconsistently emits a rename event for the file we are watching |
mscdex
reviewed
Dec 31, 2022
| await setTimeout(common.platformTimeout(100)); | ||
| fs.writeFileSync(testFile, 'hello'); | ||
|
|
||
| process.once('exit', function() { |
There was a problem hiding this comment.
Suggested change
| process.once('exit', function() { | |
| process.once('exit', () => { |
mscdex
reviewed
Dec 31, 2022
| assert(!process._getActiveHandles().some((handle) => handle.constructor.name === 'StatWatcher')); | ||
| })); | ||
|
|
||
| process.on('exit', function() { |
There was a problem hiding this comment.
Suggested change
| process.on('exit', function() { | |
| process.on('exit', () => { |
mscdex
reviewed
Dec 31, 2022
| await setTimeout(common.platformTimeout(100)); | ||
| fs.writeFileSync(testFile, 'hello'); | ||
|
|
||
| process.once('exit', function() { |
There was a problem hiding this comment.
We should also probably move this up a bit so that the handler is added before we start doing anything else like waiting for timers or writing to files.
|
@mscdex this is a backport PR, changing existing tests code will make further backporting harder since it will introduce even more conflict |
aduh95
changed the title
|
@MoLow it is recommended to specify in the PR title that it is a backport so it's easier to spot and review accordingly. |
danielleadams
force-pushed
the
v18.x-staging
branch
2 times, most recently
from
2098d7a
to
bac6b7d
Compare
PR-URL: nodejs#45501 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: nodejs#45500 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
MoLow
force-pushed
the
v18-fs-recursive-watch
branch
from
4493971
to
551a92d
Compare
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced Jan 20, 2023
juanarbol
force-pushed
the
v18.x-staging
branch
from
7351221
to
fcfde34
Compare
github-actions
bot
removed
the
request-ci
This was referenced Mar 4, 2023
This was referenced Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of
#45500
#45501