Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flakyness in test-runner reporter test #45930

Merged
merged 3 commits into from
Dec 22, 2022
Merged

test: fix flakyness in test-runner reporter test #45930

merged 3 commits into from
Dec 22, 2022

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented Dec 21, 2022

Fixes: #45929

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Dec 21, 2022
@MoLow @aduh95
Update test/parallel/test-runner-reporters.js
01b98e6 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@MoLow MoLow added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Dec 21, 2022
@MoLow
Copy link
Member Author

MoLow commented Dec 21, 2022

CC @nodejs/test_runner

@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 21, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 21, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48673/

@MoLow MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 21, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48679/

@github-actions github-actions bot mentioned this pull request Dec 22, 2022
Open
14 tasks
@GeoffreyBooth GeoffreyBooth added the fast-track PRs that do not need to wait for 48 hours to land. label Dec 22, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @GeoffreyBooth. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 22, 2022
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/45930
✔  Done loading data for nodejs/node/pull/45930
----------------------------------- PR info ------------------------------------
Title      test: fix flakyness in test-runner reporter test (#45930)
Author     Moshe Atlow  (@MoLow)
Branch     MoLow:fix-reporter-test-fluke -> nodejs:main
Labels     test, flaky-test, fast-track, author ready, needs-ci
Commits    3
 - test: fix flakyness in test-runner reporter test
 - Update test/parallel/test-runner-reporters.js
 - lint
Committers 2
 - Moshe Atlow 
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/45930
Fixes: https://github.com/nodejs/node/issues/45929
Reviewed-By: Luigi Pinca 
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Colin Ihrig 
Reviewed-By: Antoine du Hamel 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/45930
Fixes: https://github.com/nodejs/node/issues/45929
Reviewed-By: Luigi Pinca 
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Colin Ihrig 
Reviewed-By: Antoine du Hamel 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 21 Dec 2022 07:52:51 GMT
   ✔  Approvals: 4
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/45930#pullrequestreview-1226347233
   ✔  - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/45930#pullrequestreview-1226358434
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/45930#pullrequestreview-1226366242
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/45930#pullrequestreview-1226450466
   ℹ  This PR is being fast-tracked
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-12-21T19:56:28Z: https://ci.nodejs.org/job/node-test-pull-request/48679/
- Querying data for job/node-test-pull-request/48679/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 45930
From https://github.com/nodejs/node
 * branch                  refs/pull/45930/merge -> FETCH_HEAD
✔  Fetched commits as 1773b2ada4b2..49c4df76839b
--------------------------------------------------------------------------------
[main 05d974dcd0] test: fix flakyness in test-runner reporter test
 Author: Moshe Atlow 
 Date: Wed Dec 21 09:52:11 2022 +0200
 1 file changed, 1 insertion(+), 1 deletion(-)
[main b8e0cf694c] Update test/parallel/test-runner-reporters.js
 Author: Moshe Atlow 
 Date: Wed Dec 21 13:50:45 2022 +0200
 1 file changed, 3 insertions(+), 1 deletion(-)
[main a9e78837a0] lint
 Author: Moshe Atlow 
 Date: Wed Dec 21 17:37:30 2022 +0200
 1 file changed, 1 insertion(+), 1 deletion(-)
   ✔  Patches applied
There are 3 commits in the PR. Attempting autorebase.
Rebasing (2/6)

Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

test: fix flakyness in test-runner reporter test


PR-URL: #45930

Fixes: #45929

Reviewed-By: Luigi Pinca luigipinca@gmail.com

Reviewed-By: Yagiz Nizipli yagiz@nizipli.com

Reviewed-By: Colin Ihrig cjihrig@gmail.com

Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com


[detached HEAD e2b4100fbf] test: fix flakyness in test-runner reporter test

Author: Moshe Atlow moshe@atlow.co.il

Date: Wed Dec 21 09:52:11 2022 +0200

1 file changed, 1 insertion(+), 1 deletion(-)

Rebasing (3/6)

Rebasing (4/6)


Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

Update test/parallel/test-runner-reporters.js


Co-authored-by: Antoine du Hamel duhamelantoine1995@gmail.com

PR-URL: #45930

Fixes: #45929

Reviewed-By: Luigi Pinca luigipinca@gmail.com

Reviewed-By: Yagiz Nizipli yagiz@nizipli.com

Reviewed-By: Colin Ihrig cjihrig@gmail.com

Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com


[detached HEAD cc4fed35c6] Update test/parallel/test-runner-reporters.js

Author: Moshe Atlow moshe@atlow.co.il

Date: Wed Dec 21 13:50:45 2022 +0200

1 file changed, 3 insertions(+), 1 deletion(-)

Rebasing (5/6)

Rebasing (6/6)


Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

lint


PR-URL: #45930

Fixes: #45929

Reviewed-By: Luigi Pinca luigipinca@gmail.com

Reviewed-By: Yagiz Nizipli yagiz@nizipli.com

Reviewed-By: Colin Ihrig cjihrig@gmail.com

Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com


[detached HEAD ef9c4c2b8d] lint

Author: Moshe Atlow moshe@atlow.co.il

Date: Wed Dec 21 17:37:30 2022 +0200

1 file changed, 1 insertion(+), 1 deletion(-)


Successfully rebased and updated refs/heads/main.


ℹ  Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.
https://github.com/nodejs/node/actions/runs/3753956979

@GeoffreyBooth GeoffreyBooth added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Dec 22, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 22, 2022
@nodejs-github-bot nodejs-github-bot merged commit 71951a0 into nodejs:main Dec 22, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 71951a0

This was referenced Dec 23, 2022
Open
Open
Open
Open
Open
Open
Open
This was referenced Dec 30, 2022
Open
Open
targos pushed a commit that referenced this pull request Jan 1, 2023
@MoLow @targos
test: fix flakyness in test-runner reporter test
40bffe1 
PR-URL: #45930
Fixes: #45929
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jan 2, 2023
Merged
@RafaelGSS
Copy link
Member

This commit didn't land cleanly on v19.x due to the need to drop #45712. I'll include the labels dont-land-on-vXX to avoid further conflicts. Feel free to remove them when the bug is resolved.

@RafaelGSS RafaelGSS added dont-land-on-v16.x dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. labels Jan 4, 2023
RafaelGSS pushed a commit that referenced this pull request Jan 4, 2023
@MoLow @RafaelGSS
test: fix flakyness in test-runner reporter test
ce2b88d 
PR-URL: #45930
Fixes: #45929
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targos targos removed dont-land-on-v14.x dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. labels Mar 13, 2023
targos pushed a commit that referenced this pull request Mar 13, 2023
@MoLow @targos
test: fix flakyness in test-runner reporter test
ef5ce68 
PR-URL: #45930
Fixes: #45929
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request Mar 14, 2023
@MoLow @targos
test: fix flakyness in test-runner reporter test
c972612 
PR-URL: #45930
Fixes: #45929
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targos targos mentioned this pull request Mar 14, 2023
Merged
@danielleadams
Copy link
Member

This broke tests on v18.x, so requesting a backport if this should go into 18.

@danielleadams danielleadams added the backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. label Jul 1, 2023
@MoLow
Copy link
Member Author

MoLow commented Jul 2, 2023

the test on v18.x-staging behaves the same as this fix, so no need to backport

@MoLow MoLow removed the backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. label Jul 4, 2023
@ruyadorno ruyadorno added the dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. label Aug 22, 2023
@ruyadorno
Copy link
Member

adding https://github.com/nodejs/node/labels/dont-land-on-v18.x label to avoid having this show up on v18.x staging again since it's not needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@cjihrig cjihrig cjihrig approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix test-runner-reporters