Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if stream.Writable is destroyed in onwrite and final Prefinish, set emitClose = true if it is #45835

Closed
wants to merge 3 commits into from
Closed

Check if stream.Writable is destroyed in onwrite and final Prefinish, set emitClose = true if it is #45835

wants to merge 3 commits into from

Conversation

zeazad-hub
Copy link

stream/writable.js: check if stream is destroyed in onwrite and final Prefinish, set emitClose = true if it is
lib: check if stream is destroyed during _final and _write and set emitClose to true

Fixes: #39030

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/streams

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Dec 13, 2022
@mscdex
Copy link
Contributor

mscdex commented Dec 13, 2022

This doesn't seem right, why should we be overriding the stream implementer's configuration?

mcollina
mcollina requested changes Dec 13, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening a PR! Can you please add a unit test?

@Prateek462003
Copy link

Are u still working on this issue ? I would like to open a PR.

ronag
ronag requested changes Jul 11, 2023
View reviewed changes
Copy link
Member

@ronag ronag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this solving? EmitClose is not state, it's a configuration.

@RedYetiDev
Copy link
Member

Hi! It's been a while since any action happened involving this PR, and given it's current state, its unlikely that it will be added to Node.js

I'm closing this issue, but please let a team member know if you disagree.

Thank you!

@RedYetiDev RedYetiDev closed this Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina requested changes

@ronag ronag ronag requested changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Writable does not check if stream has been destroyed during _final and _write
8 participants
@zeazad-hub @nodejs-github-bot @mscdex @Prateek462003 @RedYetiDev @mcollina @ronag @daltonna