errors: refactor to use a method that formats a list string #45793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
nodejs-github-bot
added
errors
daeyeon
added
the
commit-queue-squash
aduh95
reviewed
Dec 9, 2022
|
Updated the PR to reflect the suggestions. Thanks. |
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com> Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com> Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
daeyeon
force-pushed
the
221209.Fri.69f3.main.simplify-format-list
branch
from
8d580aa to
d513efb
Compare
aduh95
reviewed
Dec 9, 2022
aduh95
reviewed
Dec 9, 2022
aduh95
reviewed
Dec 9, 2022
… message Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
|
Changed according to code review. PTAL. @aduh95 |
jasnell
approved these changes
Dec 19, 2022
aduh95
approved these changes
Dec 19, 2022
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
This was referenced Dec 20, 2022
14 tasks
13 tasks
daeyeon
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 28fe494 |
This was referenced Dec 24, 2022
This was referenced Dec 31, 2022
targos
pushed a commit
that referenced
this pull request
Jan 1, 2023
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com> PR-URL: #45793 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 4, 2023
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com> PR-URL: #45793 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 5, 2023
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com> PR-URL: #45793 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
juanarbol
pushed a commit
that referenced
this pull request
Jan 26, 2023
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com> PR-URL: #45793 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Jan 31, 2023
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com> PR-URL: #45793 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a function that creates a list string for places requiring it.
Also includes a fix for the error message of
ERR_UNSUPPORTED_ESM_URL_SCHEME.Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com