Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_runner: refactor tap_parser to use more primordials #45745

Merged
merged 2 commits into from
Dec 11, 2022
Merged

test_runner: refactor tap_parser to use more primordials #45745

merged 2 commits into from
Dec 11, 2022

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Dec 5, 2022

No description provided.

@nodejs-github-bot nodejs-github-bot added dont-land-on-v14.x needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Dec 5, 2022
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 5, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 5, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48295/

benjamingr
benjamingr previously requested changes Dec 6, 2022
View reviewed changes
Copy link
Member

@benjamingr benjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, "request changes"ing so no one lands this by mistake without benchmarks showing no regression.

If benchmarks were run - feel free to treat this "request changes" as a "lgtm"

@aduh95
Copy link
Contributor Author

aduh95 commented Dec 6, 2022 •
edited
Loading

@benjamingr we don't have benchmarks for the test runner, and IMO robustness is much more important than performance for a test runner anyway. (also it seems unlikely to me that this change would impact perf by any significant manner, but I don't have any data to back this up)

@aduh95 @VoltrexKeyva
Update lib/internal/test_runner/tap_parser.js
d339cb8 
Co-authored-by: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@aduh95 aduh95 added request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Dec 6, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 6, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48306/

This was referenced Dec 7, 2022
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48358/

@github-actions github-actions bot mentioned this pull request Dec 9, 2022
Open
5 tasks
@cjihrig cjihrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Dec 9, 2022
This was referenced Dec 10, 2022
Open
Open
@cjihrig cjihrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 11, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 11, 2022
@nodejs-github-bot nodejs-github-bot merged commit 7a42a20 into nodejs:main Dec 11, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 7a42a20

@aduh95 aduh95 deleted the tap_parser-primordials branch December 11, 2022 23:16
ErickWendel pushed a commit to ErickWendel/node that referenced this pull request Dec 12, 2022
@aduh95 @ErickWendel
test_runner: refactor tap_parser to use more primordials
3bc27a6 
PR-URL: nodejs#45745
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
targos pushed a commit that referenced this pull request Dec 12, 2022
@aduh95 @targos
test_runner: refactor tap_parser to use more primordials
27331e4 
PR-URL: #45745
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@targos targos mentioned this pull request Dec 12, 2022
Merged
targos pushed a commit that referenced this pull request Dec 13, 2022
@aduh95 @targos
test_runner: refactor tap_parser to use more primordials
ffc0f3d 
PR-URL: #45745
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@aduh95 @danielleadams
test_runner: refactor tap_parser to use more primordials
4d3a726 
PR-URL: #45745
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@aduh95 @danielleadams
test_runner: refactor tap_parser to use more primordials
ae56544 
PR-URL: #45745
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@aduh95 @danielleadams
test_runner: refactor tap_parser to use more primordials
3cee3ca 
PR-URL: #45745
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
danielleadams pushed a commit that referenced this pull request Jan 4, 2023
@aduh95 @danielleadams
test_runner: refactor tap_parser to use more primordials
70dffad 
PR-URL: #45745
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
@aduh95 @danielleadams
test_runner: refactor tap_parser to use more primordials
16cb2b6 
PR-URL: #45745
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
MoLow pushed a commit to MoLow/node-core-test that referenced this pull request Feb 2, 2023
@aduh95 @MoLow
chore: refactor tap_parser to use more primordials
9b49978 
PR-URL: nodejs/node#45745
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
(cherry picked from commit 7a42a206ac37d95060640b4812aaef32535937e1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoltrexKeyva VoltrexKeyva VoltrexKeyva left review comments

@MoLow MoLow MoLow approved these changes

@cjihrig cjihrig cjihrig approved these changes

@anonrig anonrig anonrig approved these changes

@benjamingr benjamingr benjamingr left review comments

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@aduh95 @nodejs-github-bot @benjamingr @anonrig @cjihrig @MoLow @VoltrexKeyva