Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buffer: make decodeUTF8 params loose #45610

Merged
merged 1 commit into from
Nov 27, 2022
Merged

buffer: make decodeUTF8 params loose #45610

merged 1 commit into from
Nov 27, 2022

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Nov 24, 2022 •
edited
Loading

This pull request removes the IsBoolean check for the second parameter of decodeUTF8 in order to make the parameter optional.

@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Nov 24, 2022
@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 24, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 24, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48161/

@github-actions github-actions bot mentioned this pull request Nov 25, 2022
Open
21 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48187/

@github-actions github-actions bot mentioned this pull request Nov 26, 2022
Open
21 tasks
@anonrig anonrig added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Nov 26, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48199/

@github-actions github-actions bot mentioned this pull request Nov 27, 2022
Open
21 tasks
@anonrig
Copy link
Member Author

anonrig commented Nov 27, 2022

CC @nodejs/cpp-reviewers

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 27, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 27, 2022
@nodejs-github-bot nodejs-github-bot merged commit 60810f0 into nodejs:main Nov 27, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 60810f0

This was referenced Nov 28, 2022
Open
Open
Open
ErickWendel pushed a commit to ErickWendel/node that referenced this pull request Nov 30, 2022
@anonrig @ErickWendel
buffer: make decodeUTF8 params loose
fc02232 
PR-URL: nodejs#45610
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@github-actions github-actions bot mentioned this pull request Dec 1, 2022
Open
10 tasks
targos pushed a commit that referenced this pull request Dec 12, 2022
@anonrig @targos
buffer: make decodeUTF8 params loose
1784768 
PR-URL: #45610
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@targos targos mentioned this pull request Dec 12, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@anonrig @danielleadams
buffer: make decodeUTF8 params loose
bcf1097 
PR-URL: #45610
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@anonrig @danielleadams
buffer: make decodeUTF8 params loose
4219dd5 
PR-URL: #45610
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@anonrig @danielleadams
buffer: make decodeUTF8 params loose
bfcf4f0 
PR-URL: #45610
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 4, 2023
@anonrig @danielleadams
buffer: make decodeUTF8 params loose
b92fa48 
PR-URL: #45610
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
@anonrig @danielleadams
buffer: make decodeUTF8 params loose
7aae1ff 
PR-URL: #45610
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anonrig @nodejs-github-bot @addaleax @RaisinTen