Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: headers(Distinct), trailers(Distinct) setters to be no-op #45571

Closed
wants to merge 1 commit into from
Closed

http: headers(Distinct), trailers(Distinct) setters to be no-op #45571

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Nov 22, 2022

Re-land this as a breaking change.

@Trott Trott added semver-major PRs that contain breaking changes and should be released in the next major version. notable-change PRs with changes that should be highlighted in changelogs. labels Nov 22, 2022
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net

@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 22, 2022
@nodejs-github-bot nodejs-github-bot added http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. labels Nov 22, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 22, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48083/

ShogunPanda
ShogunPanda approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@ShogunPanda ShogunPanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

aduh95
aduh95 requested changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The breakage showed that this need to go through a full deprecation cycle in order to be removed IMO.

This was referenced Nov 24, 2022
Open
Open
Trott added a commit to Trott/io.js that referenced this pull request Dec 1, 2022
@Trott
http: add doc-only deprecation for headers/trailers setters
38845b3 
Ref: nodejs#45571
@Trott Trott mentioned this pull request Dec 1, 2022
Merged
Trott added a commit to Trott/io.js that referenced this pull request Dec 1, 2022
@Trott
http: add doc-only deprecation for headers/trailers setters
286a8bb 
Ref: nodejs#45571
Trott added a commit to Trott/io.js that referenced this pull request Dec 1, 2022
@Trott
doc: add doc-only deprecation for headers/trailers setters
f73a07c 
The headers and trailers for http.IncomingMessage will be read-only in a
future version of Node.js.

Ref: nodejs#45571
Trott added a commit to Trott/io.js that referenced this pull request Dec 1, 2022
@Trott
doc: add doc-only deprecation for headers/trailers setters
70b90f7 
The headers and trailers for http.IncomingMessage will be read-only in a
future version of Node.js.

Ref: nodejs#45571
nodejs-github-bot pushed a commit that referenced this pull request Dec 3, 2022
@Trott
doc: add doc-only deprecation for headers/trailers setters
4712d60 
The headers and trailers for http.IncomingMessage will be read-only in a
future version of Node.js.

Ref: #45571
PR-URL: #45697
Refs: #45571
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Dec 12, 2022
@Trott @targos
doc: add doc-only deprecation for headers/trailers setters
9f51b9e 
The headers and trailers for http.IncomingMessage will be read-only in a
future version of Node.js.

Ref: #45571
PR-URL: #45697
Refs: #45571
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@Trott @danielleadams
doc: add doc-only deprecation for headers/trailers setters
ee569b5 
The headers and trailers for http.IncomingMessage will be read-only in a
future version of Node.js.

Ref: #45571
PR-URL: #45697
Refs: #45571
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@Trott @danielleadams
doc: add doc-only deprecation for headers/trailers setters
14a0e1b 
The headers and trailers for http.IncomingMessage will be read-only in a
future version of Node.js.

Ref: #45571
PR-URL: #45697
Refs: #45571
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@Trott @danielleadams
doc: add doc-only deprecation for headers/trailers setters
8203c02 
The headers and trailers for http.IncomingMessage will be read-only in a
future version of Node.js.

Ref: #45571
PR-URL: #45697
Refs: #45571
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 4, 2023
@Trott @danielleadams
doc: add doc-only deprecation for headers/trailers setters
625a7fa 
The headers and trailers for http.IncomingMessage will be read-only in a
future version of Node.js.

Ref: #45571
PR-URL: #45697
Refs: #45571
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
@Trott @danielleadams
doc: add doc-only deprecation for headers/trailers setters
7a56409 
The headers and trailers for http.IncomingMessage will be read-only in a
future version of Node.js.

Ref: #45571
PR-URL: #45697
Refs: #45571
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott Trott closed this Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 requested changes

@ShogunPanda ShogunPanda ShogunPanda approved these changes

Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. notable-change PRs with changes that should be highlighted in changelogs. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @nodejs-github-bot @ShogunPanda @aduh95 @sonimadhuri