Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: avoid hiding by navigation bar in anchor jumping #45131

Merged
merged 1 commit into from
May 16, 2024
Merged

doc: avoid hiding by navigation bar in anchor jumping #45131

merged 1 commit into from
May 16, 2024

Conversation

cloydlau
Copy link
Contributor

@cloydlau cloydlau commented Oct 23, 2022

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 23, 2022
@mscdex
Copy link
Contributor

mscdex commented Oct 23, 2022

Fixes #42286 ?

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels May 12, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 16, 2024
@nodejs-github-bot nodejs-github-bot merged commit b0bd534 into nodejs:main May 16, 2024
20 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in b0bd534

targos pushed a commit that referenced this pull request May 21, 2024
PR-URL: #45131
Fixes: #42286
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jun 7, 2024
sophoniie pushed a commit to sophoniie/node that referenced this pull request Jun 20, 2024
PR-URL: nodejs#45131
Fixes: nodejs#42286
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
PR-URL: nodejs#45131
Fixes: nodejs#42286
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@ChALkeR
Copy link
Member

ChALkeR commented Jun 29, 2024

I think that navigating the documentation is significantly broken now

Not sure if it's by this change, or by combination with smooth scrolling, or by any other changes in the doc structure, but navigating 22.x docs just scrolls to incorrect locations

  • 20.x docs work fine (but with minor offset)
  • 22.2.0 docs work fine (but also with a minor offset)
  • 22.3.0 docs scroll to completely wrong locations
  • 22.x docs on github work fine

@cloydlau
Copy link
Contributor Author

cloydlau commented Jul 1, 2024

@ChALkeR Hello, this PR was proposed on Octobe 2022, at that time Node 22 had not yet been released. It might be caused by scroll-padding-top: 50vh;. Therefore I submitted a PR to fix it.

@cloydlau
Copy link
Contributor Author

cloydlau commented Jul 1, 2024

However, this issue still exists in the Node 17 documentation. I submitted this PR to specifically address the documentation for Node 17.

marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
PR-URL: #45131
Fixes: #42286
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
PR-URL: #45131
Fixes: #42286
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doc: HTML API docs' fixed header obscures anchored content
5 participants