-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: avoid hiding by navigation bar in anchor jumping #45131
Conversation
Fixes #42286 ? |
Landed in b0bd534 |
PR-URL: nodejs#45131 Fixes: nodejs#42286 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: nodejs#45131 Fixes: nodejs#42286 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
I think that navigating the documentation is significantly broken now Not sure if it's by this change, or by combination with smooth scrolling, or by any other changes in the doc structure, but navigating 22.x docs just scrolls to incorrect locations
|
However, this issue still exists in the Node 17 documentation. I submitted this PR to specifically address the documentation for Node 17. |
Reproduction link: https://nodejs.org/docs/latest-v17.x/api/url.html#class-urlsearchparams
Fixes: #42286