Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v14.x backport] tools: add more options to track flaky tests #45126

Closed
wants to merge 2 commits into from
Closed

[v14.x backport] tools: add more options to track flaky tests #45126

wants to merge 2 commits into from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Oct 22, 2022

Backport of #43954, needed for nodejs/build#3056.

@aduh95
tools: add more options to track flaky tests
e8318a1 
Refs: nodejs#43929 (comment)

PR-URL: nodejs#43954
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Feng Yu <F3n67u@outlook.com>
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added meta Issues and PRs related to the general management of the project. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory. v14.x labels Oct 22, 2022
@aduh95 aduh95 mentioned this pull request Oct 22, 2022
Merged
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 22, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 22, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47405/

@richardlau
Copy link
Member

This will need changes so that it also works with Python 2 if it is to land in v14.x.

@richardlau richardlau removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 22, 2022
aduh95
aduh95 commented Oct 22, 2022
View reviewed changes
tools/test.py Outdated Show resolved Hide resolved
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 22, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 22, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47409/

@github-actions github-actions bot mentioned this pull request Oct 23, 2022
Open
13 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47412/

@github-actions github-actions bot mentioned this pull request Oct 24, 2022
Open
13 tasks
@aduh95
Copy link
Contributor Author

aduh95 commented Oct 24, 2022

@nodejs/lts can this be merged to unblock nodejs/build#3056 please?

@richardlau richardlau mentioned this pull request Oct 24, 2022
Merged
mhdawson
mhdawson approved these changes Oct 24, 2022
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was referenced Oct 25, 2022
Open
Open
danielleadams pushed a commit that referenced this pull request Oct 26, 2022
@aduh95 @danielleadams
tools: add more options to track flaky tests
a1d5209 
Refs: #43929 (comment)

PR-URL: #43954
Backport-PR-URL: #45126
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Feng Yu <F3n67u@outlook.com>
@danielleadams
Copy link
Contributor

Landed in a1d5209

@aduh95 aduh95 deleted the backport-v14-mesure-flakiness branch October 26, 2022 23:14
@github-actions github-actions bot mentioned this pull request Oct 27, 2022
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@mhdawson mhdawson mhdawson approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aduh95 @nodejs-github-bot @richardlau @danielleadams @mhdawson @RafaelGSS