deps: update Base64 SIMD library

[lucshi]

Update the Base64 SIMD library which include new features of AVX512 support and AVX inline assembly and several bug fixes.

Fixes: #45089

[nodejs-github-bot]

Review requested:

• @nodejs/gyp

[lucshi]

Were the checking errors caused by CI system issue?

[mscdex]

Some of the failures are legitimate, for example on armv7l:

21:31:04 ../deps/base64/base64/lib/arch/ssse3/codec.c:12:10: fatal error: tmmintrin.h: No such file or directory
21:31:05    12 | #include <tmmintrin.h>
21:31:05       |          ^~~~~~~~~~~~~
21:31:05 compilation terminated.
21:31:05 make[2]: *** [deps/base64/base64.target.mk:100: /home/iojs/build/workspace/node-test-commit-arm/out/Release/obj.target/base64/deps/base64/base64/lib/arch/ssse3/codec.o] Error 1
21:31:05 make[2]: *** Waiting for unfinished jobs....
21:31:05 ../deps/base64/base64/lib/arch/sse42/codec.c:12:10: fatal error: nmmintrin.h: No such file or directory
21:31:05    12 | #include <nmmintrin.h>
21:31:05       |          ^~~~~~~~~~~~~
21:31:05 compilation terminated.
21:31:05 ../deps/base64/base64/lib/arch/sse41/codec.c:12:10: fatal error: smmintrin.h: No such file or directory
21:31:05    12 | #include <smmintrin.h>
21:31:05       |          ^~~~~~~~~~~~~
21:31:05 compilation terminated.
21:31:05 ../deps/base64/base64/lib/arch/avx/codec.c:12:10: fatal error: immintrin.h: No such file or directory
21:31:05    12 | #include <immintrin.h>
21:31:05       |          ^~~~~~~~~~~~~
21:31:05 compilation terminated.
21:31:05 make[2]: *** [deps/base64/base64.target.mk:100: /home/iojs/build/workspace/node-test-commit-arm/out/Release/obj.target/base64/deps/base64/base64/lib/arch/sse42/codec.o] Error 1
21:31:05 make[2]: *** [deps/base64/base64.target.mk:100: /home/iojs/build/workspace/node-test-commit-arm/out/Release/obj.target/base64/deps/base64/base64/lib/arch/sse41/codec.o] Error 1
21:31:05 make[2]: *** [deps/base64/base64.target.mk:100: /home/iojs/build/workspace/node-test-commit-arm/out/Release/obj.target/base64/deps/base64/base64/lib/arch/avx/codec.o] Error 1
21:31:05 ../deps/base64/base64/lib/arch/avx2/codec.c:12:10: fatal error: immintrin.h: No such file or directory
21:31:05    12 | #include <immintrin.h>
21:31:05       |          ^~~~~~~~~~~~~
21:31:05 compilation terminated.
21:31:05 make[2]: *** [deps/base64/base64.target.mk:100: /home/iojs/build/workspace/node-test-commit-arm/out/Release/obj.target/base64/deps/base64/base64/lib/arch/avx2/codec.o] Error 1

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/47375/

[lucshi]

I suppose no actual errors in the CI..

[lucshi]

Is there someone reviewing this PR?

[juanarbol]

Ci hit a flaky test, I will run the CI again

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/47497/

[jasnell]

Rubber-stamp LGTM

[lucshi]

May I know if there was problems in CI?

[lucshi]

May I know if there is some revisement needed before it could be landed. @mscdex

[lucshi]

I'm wondering what blocked this PR merge. Could someone restart the CI and see if CI unstable issue is gone? @juanarbol

[bnoordhuis]

@lucshi I can restart CI but you probably want to rebase on top off the main branch first.

[mhdawson]

@lucshi did you copy over the lastest in the main branch or what is tagged with v0.5.0. I'm thinking we should likely update to a known tag, but I can see that the current instructions don't say that.

[mhdawson]

I can now see from the history that new automation updated recently to v0.5.0.

[mhdawson]

I can see in the discussion of the automatic update this comment:

There is a Base64 update patch in PR #45091 which is approved but not merged yet. To make the latest Base64 works best, it needs changes in gyp files as in that PR.

I'm thinking we should be waiting for the PR to land in the upstream unless there is an urgent need to float the patch which might changed/not merged?

[mhdawson]

@jasnell, @anonrig is there more context that I've missed which pushes for this getting landed before it does in the upstream?

[anonrig]

@jasnell, @anonrig is there more context that I've missed which pushes for this getting landed before it does in the upstream?

Let's wait for base64 to do a new release, and automatically update it when the time comes (through the update script).

[lucshi]

I can see in the discussion of the automatic update this comment:

There is a Base64 update patch in PR #45091 which is approved but not merged yet. To make the latest Base64 works best, it needs changes in gyp files as in that PR.

I'm thinking we should be waiting for the PR to land in the upstream unless there is an urgent need to float the patch which might changed/not merged?

Thanks! There is no much urgent needs. Let's wait for Base64 new release.

[Uzlopak]

The necessary changes seem to be landed in upstream.

But the maintainer @aklomp did not released it.

@lemire
@anonrig

It seems that avx512 is just implemented for encoding and fallback to AVX2 for decoding. Erm.. i have no experience with simd, but maybe this is an easy task for you @lemire? Or maybe takes an effort... Idk. I cant estimate the work. But maybe this is something that interests you?

[aklomp]

@Uzlopak I just released base64 v0.5.1 which has all the latest changes.