node-api: create reference only when needed #44827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
Optimize napi_create_external() to create the reference for calling finalizer only if user actually provides a finalizer callback.
Flarna
force-pushed
the
napi-external-no-ref
branch
from
4419559 to
41662d5
Compare
Flarna
changed the title
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
lpinca
approved these changes
Oct 1, 2022
github-actions
bot
removed
the
request-ci
daeyeon
approved these changes
Oct 2, 2022
daeyeon
added
the
author ready
github-actions
bot
removed
the
request-ci
jasnell
approved these changes
Oct 2, 2022
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Flarna
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in ecd5de0 |
16 tasks
panva
pushed a commit
to panva/node
that referenced
this pull request
Oct 4, 2022
Optimize napi_create_external() to create the reference for calling finalizer only if user actually provides a finalizer callback. PR-URL: nodejs#44827 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Oct 5, 2022
danielleadams
pushed a commit
that referenced
this pull request
Oct 11, 2022
Optimize napi_create_external() to create the reference for calling finalizer only if user actually provides a finalizer callback. PR-URL: #44827 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize
napi_create_external()to create the reference for calling finalizer only if user actually provides a finalizer callback.