Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: restore IS_RELEASE to 0 #44758

Merged
merged 1 commit into from
Sep 24, 2022
Merged

src: restore IS_RELEASE to 0 #44758

merged 1 commit into from
Sep 24, 2022

Conversation

bengl
Copy link
Member

@bengl bengl commented Sep 23, 2022 •
edited
Loading

This was accidentally left in during the most recent security release process.

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Sep 23, 2022
@ruyadorno ruyadorno added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 23, 2022
@RafaelGSS RafaelGSS added dont-land-on-v14.x dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. and removed fast-track PRs that do not need to wait for 48 hours to land. labels Sep 23, 2022
@bengl bengl added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 23, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @ruyadorno. Please 👍 to approve.

@github-actions
Copy link
Contributor

Fast-track has been requested by @bengl. Please 👍 to approve.

@tniessen tniessen mentioned this pull request Sep 23, 2022
Merged
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 23, 2022
@MylesBorins
Copy link
Contributor

I'd like to propose that we just land this and don't wait for CI since all the changes are a single bit flip that will itself unbreak CI

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 23, 2022
@tniessen
Copy link
Member

tniessen commented Sep 23, 2022 •
edited
Loading

ASan failure is due to #44735. I restarted the job but it might not be worth waiting for.

Edit: second attempt also failed because of the same test.

@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 23, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 23, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46730/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46733/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46739/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46740/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46741/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46742/

@tniessen
Copy link
Member

@nodejs/build It looks like CI runs into infra failures every time.

21:59:18 FATAL: Connection timed out
21:59:18 java.net.ConnectException: Connection timed out

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46744/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46745/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46747/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46748/

@tniessen
Copy link
Member

We haven't had a successful Jenkins run on any PR since yesterday morning, see nodejs/build#3037.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46751/

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 24, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 24, 2022
@nodejs-github-bot nodejs-github-bot merged commit 45f2258 into nodejs:main Sep 24, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 45f2258

@daeyeon daeyeon mentioned this pull request Sep 25, 2022
Merged
@github-actions github-actions bot mentioned this pull request Sep 26, 2022
Open
18 tasks
@daeyeon daeyeon mentioned this pull request Sep 26, 2022
Merged
@github-actions github-actions bot mentioned this pull request Sep 27, 2022
Open
14 tasks
@RafaelGSS RafaelGSS mentioned this pull request Oct 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@aduh95 aduh95 aduh95 approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@richardlau richardlau richardlau approved these changes

@tniessen tniessen tniessen approved these changes

@Trott Trott Trott approved these changes

@bnb bnb bnb approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

@ruyadorno ruyadorno ruyadorno approved these changes

Assignees
No one assigned
Labels
dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.