Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: upgrade npm to v9.0.0-pre.2 #44756

Closed
wants to merge 2 commits into from
Closed

deps: upgrade npm to v9.0.0-pre.2 #44756

wants to merge 2 commits into from

Conversation

MylesBorins
Copy link
Contributor

This is a draft PR to do integration tests between the latest npm v9 release candidate and Node.js. Please feel free to leave any comments.

Please refer to npm/statusboard#443 for the full list of intended breaking changes for v9

https://github.com/npm/cli/releases/tag/v9.0.0-pre.0
https://github.com/npm/cli/releases/tag/v9.0.0-pre.1
https://github.com/npm/cli/releases/tag/v9.0.0-pre.2

For the change logs of what has been implemented up until now.

@nodejs-github-bot nodejs-github-bot added dont-land-on-v14.x fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry. labels Sep 23, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @nodejs-github-bot. Please 👍 to approve.

@MylesBorins MylesBorins mentioned this pull request Sep 23, 2022
Closed
mcollina
mcollina approved these changes Sep 23, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina added dont-land-on-v16.x dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. labels Sep 23, 2022
@MylesBorins MylesBorins marked this pull request as draft September 23, 2022 18:11
@MylesBorins MylesBorins marked this pull request as ready for review September 23, 2022 18:13
@MylesBorins MylesBorins added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 23, 2022
@MylesBorins
Copy link
Contributor Author

MylesBorins commented Sep 23, 2022 •
edited
Loading

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2995/
CITGM run against 96f0722 for comparison: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2987/

Another citgm run: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2996/

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 23, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot mentioned this pull request Sep 26, 2022
Open
18 tasks
@MylesBorins MylesBorins force-pushed the update-npm-9.0.0-pre.2 branch from 3fb0529 to 2ada1ee Compare September 26, 2022 18:41
@MylesBorins MylesBorins added request-ci Add this label to start a Jenkins CI on a PR. and removed fast-track PRs that do not need to wait for 48 hours to land. labels Sep 26, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 26, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 26, 2022 •
edited by MylesBorins
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/46831/
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2998/

@github-actions github-actions bot mentioned this pull request Sep 27, 2022
Open
14 tasks
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 27, 2022 •
edited by MylesBorins
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/46846/
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3003/

This was referenced Sep 28, 2022
Open
Open
@MylesBorins MylesBorins mentioned this pull request Oct 3, 2022
Closed
@MylesBorins
Copy link
Contributor Author

close in lieu of #44879

@MylesBorins MylesBorins closed this Oct 3, 2022
@MylesBorins MylesBorins deleted the update-npm-9.0.0-pre.2 branch October 3, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MylesBorins @nodejs-github-bot @mcollina