Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: remove abortReason from WritableStreamDefaultController #44540

Merged
merged 1 commit into from
Sep 9, 2022
Merged

stream: remove abortReason from WritableStreamDefaultController #44540

merged 1 commit into from
Sep 9, 2022

Conversation

daeyeon
Copy link
Member

@daeyeon daeyeon commented Sep 6, 2022 •
edited
Loading

The abortReason property has been removed from the spec since we can get
the abort reason via writableStreamDefaultController.signal.reason.

[Exposed=*]
interface WritableStreamDefaultController {
  readonly attribute AbortSignal signal;
  undefined error(optional any e);
};

This reflects the change and removes a TODO left as a follow-up of #44327.

Refs: https://streams.spec.whatwg.org/#ws-default-controller-class-definition

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com

@daeyeon
stream: remove abortReason from WritableStreamDefaultController
e39a3bc 
The `abortReason` has been removed from the spec since we can get
the abort reason via `controller.signal.reason`.

This reflects the change.

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. web streams labels Sep 6, 2022
@daeyeon
Copy link
Member Author

daeyeon commented Sep 6, 2022

/cc @nodejs/whatwg-stream

@daeyeon daeyeon added semver-major PRs that contain breaking changes and should be released in the next major version. and removed semver-major PRs that contain breaking changes and should be released in the next major version. labels Sep 6, 2022
mcollina
mcollina approved these changes Sep 6, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mcollina
mcollina approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 7, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 7, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/46470/

@daeyeon daeyeon added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 8, 2022
@mcollina mcollina added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 9, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 9, 2022
@nodejs-github-bot nodejs-github-bot merged commit a4b2641 into nodejs:main Sep 9, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in a4b2641

Fyko pushed a commit to Fyko/node that referenced this pull request Sep 15, 2022
@daeyeon @Fyko
stream: remove abortReason from WritableStreamDefaultController
1239f5d 
The `abortReason` has been removed from the spec since we can get
the abort reason via `controller.signal.reason`.

This reflects the change.

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
PR-URL: nodejs#44540
Refs: https://streams.spec.whatwg.org/#ws-default-controller-class-definition
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@daeyeon daeyeon deleted the main.remove.todo-220906.Tue.3a7b branch September 23, 2022 17:06
RafaelGSS pushed a commit that referenced this pull request Sep 26, 2022
@daeyeon @RafaelGSS
stream: remove abortReason from WritableStreamDefaultController
00185f1 
The `abortReason` has been removed from the spec since we can get
the abort reason via `controller.signal.reason`.

This reflects the change.

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
PR-URL: #44540
Refs: https://streams.spec.whatwg.org/#ws-default-controller-class-definition
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Sep 26, 2022
Merged
RafaelGSS pushed a commit that referenced this pull request Sep 26, 2022
@daeyeon @RafaelGSS
stream: remove abortReason from WritableStreamDefaultController
5382877 
The `abortReason` has been removed from the spec since we can get
the abort reason via `controller.signal.reason`.

This reflects the change.

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
PR-URL: #44540
Refs: https://streams.spec.whatwg.org/#ws-default-controller-class-definition
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Sep 26, 2022
@daeyeon @RafaelGSS
stream: remove abortReason from WritableStreamDefaultController
0af6e42 
The `abortReason` has been removed from the spec since we can get
the abort reason via `controller.signal.reason`.

This reflects the change.

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
PR-URL: #44540
Refs: https://streams.spec.whatwg.org/#ws-default-controller-class-definition
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@juanarbol
Copy link
Member

This seems to break the wpt tests in the v16.x release branch; do you think you could backport this?

@daeyeon
Copy link
Member Author

daeyeon commented Oct 3, 2022 •
edited
Loading

Backporting this is pending now since it depends on #43455, #44234, and #44327. I'd like to check first whether I could use the WPT Runner update on the release line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@benjamingr benjamingr benjamingr approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. web streams
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@daeyeon @nodejs-github-bot @juanarbol @mcollina @benjamingr @lpinca