Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: make utils.SearchFiles deterministic #44496

Merged
merged 1 commit into from
Oct 4, 2022

Commits on Sep 5, 2022

  1. tools: make utils.SearchFiles deterministic

    `glob.glob` on Linux returns files in the order returned by the
    filesystem driver, and the output from this function is stuffed by
    the Electron build process straight into the `config.gypi` header,
    causing non-reproducible builds.
    
    See this log for an example of the nondeterminism:
    https://rb.zq1.de/compare.factory-20220901/diffs/nodejs-electron-compare.out
    brjsp committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    30253ac View commit details
    Browse the repository at this point in the history