Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix readme - make install should be run as a superuser #444

Closed
wants to merge 1 commit into from
Closed

doc: fix readme - make install should be run as a superuser #444

wants to merge 1 commit into from

Conversation

GlenTiki
Copy link
Contributor

Am I being pedantic? Probably. Might be worth throwing in the official repo for dummies scratching their heads for 15 minutes wondering why it won't install.

@bnoordhuis
Copy link
Member

This is a good first step but there are a number of reasons why indiscriminately using sudo is maybe not a good idea:

  1. It's not necessary (and possibly harmful) on systems where /usr/local is writable.
  2. Not all systems use sudo (newbies probably don't use such systems, though.)

Maybe change it to: $ make install # or: sudo make install?

@bnoordhuis
Copy link
Member

Oh, and please update the commit log. See CONTRIBUTING.md for guidance on what it should look like.

@silverwind
Copy link
Contributor

I think it's pretty common to write [sudo] command to mark it optional.

@rvagg
Copy link
Member

rvagg commented Jan 16, 2015

I'm not a huge fan of [sudo] but it is a bit of a convention so lgtm, @thekemkid can you squash your commits into one please?

bnoordhuis pushed a commit that referenced this pull request Jan 19, 2015
PR-URL: #444
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rod Vagg <rod@vagg.org>
@bnoordhuis
Copy link
Member

Thanks, landed in ab04a43 with small changes to the commit log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants