test: mark test-gc-http-client-timeout as flaky on arm #43754
Conversation
nodejs-github-bot
added
needs-ci
legendecas
added
the
fast-track
|
Requesting fast track since this is purely a status file change. |
|
Fast-track has been requested by @legendecas. Please 👍 to approve. |
legendecas
force-pushed
the
flaky-test-gc-http-client-timeout
branch
from
7e807c8 to
71ffde5
Compare
legendecas
force-pushed
the
flaky-test-gc-http-client-timeout
branch
from
71ffde5 to
aaa5461
Compare
|
Should we wait until @ShogunPanda's investigation is done? See #43641 (comment). |
|
@lpinca the intention of this PR is to unblock other PR that have been retrying the CI again and again. I think #43641 is still able to run stress tests with https://ci.nodejs.org/job/node-stress-single-test/ to make sure the fix is effective. |
|
@legendecas I understand but a lot of tests have been marked as flaky lately. Ideally we should fix them and remove the flaky designation. |
|
@lpinca Sorry, but I may not get your point clearly. Do you suggest that we should not mark tests as flaky and wait until they are fixed? Marking the flaky tests and keeping track of them asynchronously unblocks other contributors from landing a PR that is not related to the flaky tests. I believe it is vital for helping contributors not be overwhelmed by the constantly failing CI because of flaky tests. As the change seems to be contentious, I'm removing the fast-track label. |
legendecas
removed
the
fast-track
No, I'm fine with this. I'm just concerned about the growing number of flaky tests. |
|
Fast-track has been requested by @lpinca. Please 👍 to approve. |
|
CI flakiness is a major problem at this point. Most recently, #43522 landed despite relevant test failures, blocking other contributors' work, and there was pushback against reverting it. It took days to fix the tests (to some degree). I can only assume that this happened because CI was resumed multiple times without investigating the actual errors, which probably would not happen if CI did not constantly fail due to unrelated errors. My take is: mark everything as flaky that is indeed flaky. Once that is done, every CI failure is worth investigating in detail, and we can treat the list of flaky tests as a to-do list. |
github-actions
bot
removed
the
request-ci
`sequential/test-gc-http-client-timeout` is failing on arm frequently. Mark it as flaky to unblock PRs to land. PR-URL: #43754 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
|
Landed in c6ec630, thank you for reviewing! |
`sequential/test-gc-http-client-timeout` is failing on arm frequently. Mark it as flaky to unblock PRs to land. PR-URL: #43754 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
`sequential/test-gc-http-client-timeout` is failing on arm frequently. Mark it as flaky to unblock PRs to land. PR-URL: #43754 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
`sequential/test-gc-http-client-timeout` is failing on arm frequently. Mark it as flaky to unblock PRs to land. PR-URL: #43754 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
`sequential/test-gc-http-client-timeout` is failing on arm frequently. Mark it as flaky to unblock PRs to land. PR-URL: nodejs/node#43754 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
sequential/test-gc-http-client-timeoutis failing on arm frequently. Mark it as flaky to unblock PRs to land.Related: nodejs/reliability#320
Related: #43638