Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix test stream finished #43633

Closed
wants to merge 1 commit into from
Closed

test: fix test stream finished #43633

wants to merge 1 commit into from

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented Jun 30, 2022

fixes #43623 (Hopefully 🙌 )

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jun 30, 2022
@tniessen tniessen added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 30, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 30, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45015/

@F3n67u
Copy link
Member

F3n67u commented Jun 30, 2022

Not fixed. test-stream-finished is still failing in linux https://ci.nodejs.org/job/node-test-commit-linux/46372/nodes=rhel8-x64/testReport/junit/(root)/test/parallel_test_stream_finished/

This was referenced Jul 1, 2022
Merged
Closed
@MoLow
Copy link
Member Author

MoLow commented Jul 3, 2022

fixed in #43641

@MoLow MoLow closed this Jul 3, 2022
@MoLow MoLow deleted the fix-test-streap-finished branch July 3, 2022 07:27
@github-actions github-actions bot mentioned this pull request Jul 4, 2022
Open
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate flaky test-stream-finished
4 participants
@MoLow @nodejs-github-bot @F3n67u @tniessen