Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: fix net keepalive and noDelay #43561

Merged
merged 1 commit into from
Jun 29, 2022
Merged

net: fix net keepalive and noDelay #43561

merged 1 commit into from
Jun 29, 2022

Conversation

theanarkh
Copy link
Contributor

  1. support call setKeepAlive again with different delay value.
  2. set keepalive and nodelay to socket which is created by server.
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Affected subsystem: net

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. net Issues and PRs related to the net subsystem. labels Jun 24, 2022
@theanarkh
net: fix net keepalive and noDelay
474849d 
1. support setKeepAlive again
2. set keepalive and nodelay to socket which is created by server
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44876/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44882/

@github-actions github-actions bot mentioned this pull request Jun 27, 2022
Open
33 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44892/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44904/

@github-actions github-actions bot mentioned this pull request Jun 28, 2022
Open
32 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44932/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44934/

@F3n67u F3n67u mentioned this pull request Jun 28, 2022
Closed
@github-actions github-actions bot mentioned this pull request Jun 29, 2022
Open
23 tasks
@mcollina mcollina added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed needs-ci PRs that need a full CI run. labels Jun 29, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 29, 2022
@nodejs-github-bot nodejs-github-bot merged commit 8e19dab into nodejs:main Jun 29, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 8e19dab

mabaasit pushed a commit to mabaasit/node that referenced this pull request Jul 6, 2022
@theanarkh @mabaasit
net: fix net keepalive and noDelay
18cc291 
1. support setKeepAlive again
2. set keepalive and nodelay to socket which is created by server

PR-URL: nodejs#43561
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jul 12, 2022
@theanarkh @targos
net: fix net keepalive and noDelay
ad1d054 
1. support setKeepAlive again
2. set keepalive and nodelay to socket which is created by server

PR-URL: #43561
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Jul 12, 2022
Merged
targos pushed a commit that referenced this pull request Jul 20, 2022
@theanarkh @targos
net: fix net keepalive and noDelay
5e3cde3 
1. support setKeepAlive again
2. set keepalive and nodelay to socket which is created by server

PR-URL: #43561
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
@theanarkh @targos
net: fix net keepalive and noDelay
ff5310a 
1. support setKeepAlive again
2. set keepalive and nodelay to socket which is created by server

PR-URL: #43561
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@theanarkh @guangwong
net: fix net keepalive and noDelay
d3b9659 
1. support setKeepAlive again
2. set keepalive and nodelay to socket which is created by server

PR-URL: nodejs/node#43561
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mscdex mscdex mscdex left review comments

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. net Issues and PRs related to the net subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@theanarkh @nodejs-github-bot @mscdex @jasnell @lpinca @mcollina