Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: upgrade npm to 8.13.1 #43552

Merged
merged 1 commit into from
Jun 25, 2022
Merged

deps: upgrade npm to 8.13.1 #43552

merged 1 commit into from
Jun 25, 2022

Conversation

npm-cli-bot
Copy link
Contributor

@npm-cli-bot npm-cli-bot commented Jun 23, 2022 •
edited by lpinca
Loading

v8.13.1 (2022-06-23)

Dependencies

v8.13.0 (2022-06-22)

Features

  • 06fd788 #4960 feat: prompt before opening web-login URL when performing login/adduser (@jumoel)

Bug Fixes

Documentation

Dependencies

@nodejs-github-bot nodejs-github-bot added dont-land-on-v14.x fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry. labels Jun 23, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @nodejs-github-bot. Please 👍 to approve.

@lpinca lpinca mentioned this pull request Jun 24, 2022
Closed
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 24, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 24, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44841/

@github-actions github-actions bot mentioned this pull request Jun 25, 2022
Open
32 tasks
@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 25, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 25, 2022
@nodejs-github-bot nodejs-github-bot merged commit 687e50a into nodejs:main Jun 25, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 687e50a

This was referenced Jun 26, 2022
Open
Open
Open
targos pushed a commit that referenced this pull request Jul 12, 2022
@npm-cli-bot @targos
deps: upgrade npm to 8.13.1
0636f86 
PR-URL: #43552
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@targos targos mentioned this pull request Jul 12, 2022
Merged
targos pushed a commit that referenced this pull request Jul 18, 2022
@npm-cli-bot @targos
deps: upgrade npm to 8.13.1
f951bd6 
PR-URL: #43552
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
jtojnar added a commit to jtojnar/nixfiles that referenced this pull request Jul 21, 2022
@jtojnar
flake.lock: Update
25feecd 
Flake lock file updates:

• Updated input 'home-manager':
    'github:nix-community/home-manager/2c94b9801f1a11cde0fc97aa850687bb9137d42c' (2022-07-13)
  → 'github:nix-community/home-manager/4c5106ed0f3168ff2df21b646aef67e86cbfc11c' (2022-07-15)
• Updated input 'nixpkgs':
    'github:nixos/nixpkgs/38860c9e91cb00f4d8cd19c7b4e36c45680c89b5' (2022-07-11)
  → 'github:nixos/nixpkgs/8f485713f5e6b6883a9b6959afa98688360a3ecb' (2022-07-16)

Also had to downgrade Node.js version in Pengu since it started to fail with:

	npm info run @parcel/watcher@2.0.5 install node_modules/@parcel/watcher node-gyp-build
	npm info run bufferutil@4.0.6 install node_modules/bufferutil node-gyp-build
	npm info run lmdb@2.2.4 install node_modules/lmdb node-gyp-build
	npm info run msgpackr-extract@2.0.2 install node_modules/msgpackr-extract node-gyp-build-optional-packages
	npm info run utf-8-validate@5.0.9 install node_modules/utf-8-validate node-gyp-build
	npm info run utf-8-validate@5.0.9 install { code: 126, signal: null }e@5.
	npm info run msgpackr-extract@2.0.2 install { code: 126, signal: null }
	npm verb reify failed optional dependency /build/source/node_modules/msgpackr-extract
	npm verb reify failed optional dependency /build/source/node_modules/node-gyp-build-optional-packages
	npm timing build:run:install:node_modules/msgpackr-extract Completed in 35ms
	npm info run lmdb@2.2.4 install { code: 126, signal: null }
	npm info run bufferutil@4.0.6 install { code: 126, signal: null }
	npm info run @parcel/watcher@2.0.5 install { code: 126, signal: null }
	npm timing reify:rollback:createSparse Completed in 403msr@2r@2
	npm timing reify:rollback:retireShallow Completed in 0ms
	npm timing command:install Completed in 6310ms
	npm verb stack Error: command failed
	npm verb stack     at ChildProcess.<anonymous> (/nix/store/vcfm2pcj8dl8inyg93hwrbwkfn3kfr7v-nodejs-18.6.0/lib/node_modules/npm/node_modules/@npmcli/promise-spawn/lib/index.js:63:27)
	npm verb stack     at ChildProcess.emit (node:events:513:28)
	npm verb stack     at maybeClose (node:internal/child_process:1091:16)
	npm verb stack     at Socket.<anonymous> (node:internal/child_process:449:11)
	npm verb stack     at Socket.emit (node:events:513:28)
	npm verb stack     at Pipe.<anonymous> (node:net:757:14)
	npm verb pkgid utf-8-validate@5.0.9
	npm verb cwd /build/source
	npm verb Linux 5.18.10
	npm verb node v18.6.0
	npm verb npm  v8.13.2
	npm ERR! code 126
	npm ERR! path /build/source/node_modules/utf-8-validate
	npm ERR! command failed
	npm ERR! command sh -c /build/install6584764974.sh
	npm ERR! sh: /build/install6584764974.sh: /usr/bin/env: bad interpreter: No such file or directory
	npm verb exit 126

But bumping its dependencies did not help.

Bisected that to to the following commit in Nixpkgs:

	commit 5ad0643e1c0b6ec442754b34316814ea212a76a3
	Author: R. Ryantm <ryantm-bot@ryantm.com>
	Date:   Thu Jul 14 10:05:53 2022 +0000

	    nodejs-18_x: 18.5.0 -> 18.6.0

And node.js:

	commit 0636f86eccdf1c343fe94c16926160dbdefa2553
	Author: npm CLI robot <npm-cli+bot@github.com>
	Date:   Fri Jun 24 18:21:50 2022 -0700

	    deps: upgrade npm to 8.13.1

	    PR-URL: nodejs/node#43552
targos pushed a commit that referenced this pull request Jul 31, 2022
@npm-cli-bot @targos
deps: upgrade npm to 8.13.1
1343615 
PR-URL: #43552
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@npm-cli-bot @guangwong
deps: upgrade npm to 8.13.1
bda33fc 
PR-URL: nodejs/node#43552
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

@tniessen tniessen tniessen approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@npm-cli-bot @nodejs-github-bot @lpinca @tniessen @VoltrexKeyva @richardlau