test: replace gc(true) with gc({ type: 'minor' })

[tniessen]

V8 considers gc(true) legacy, and the new signature is much more expressive.

node/deps/v8/src/extensions/gc-extension.cc

Lines 42 to 79 in 94020ac

	Maybe<GCOptions> Parse(v8::Isolate* isolate,
	const v8::FunctionCallbackInfo<v8::Value>& args) {
	// Default values.
	auto options =
	GCOptions{v8::Isolate::GarbageCollectionType::kFullGarbageCollection,
	ExecutionType::kSync};
	bool found_options_object = false;
	if (args.Length() > 0 && args[0]->IsObject()) {
	v8::HandleScope scope(isolate);
	auto ctx = isolate->GetCurrentContext();
	auto param = v8::Local<v8::Object>::Cast(args[0]);
	auto maybe_type = IsProperty(isolate, ctx, param, "type", "minor");
	if (maybe_type.IsNothing()) return Nothing<GCOptions>();
	if (maybe_type.ToChecked()) {
	found_options_object = true;
	options.type =
	v8::Isolate::GarbageCollectionType::kMinorGarbageCollection;
	}
	auto maybe_execution =
	IsProperty(isolate, ctx, param, "execution", "async");
	if (maybe_execution.IsNothing()) return Nothing<GCOptions>();
	if (maybe_execution.ToChecked()) {
	found_options_object = true;
	options.execution = ExecutionType::kAsync;
	}
	}
	// If no options object is present default to legacy behavior.
	if (!found_options_object) {
	options.type =
	args[0]->BooleanValue(isolate)
	? v8::Isolate::GarbageCollectionType::kMinorGarbageCollection
	: v8::Isolate::GarbageCollectionType::kFullGarbageCollection;
	}
	return Just<GCOptions>(options);
	}

[mcollina]

lgtm

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/44763/

[nodejs-github-bot]

Landed in f5ce6b1