Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src,bootstrap: remove NodeMainInstance::registry_ #43392

Merged
merged 1 commit into from
Jun 30, 2022
Merged

src,bootstrap: remove NodeMainInstance::registry_ #43392

merged 1 commit into from
Jun 30, 2022

Conversation

RaisinTen
Copy link
Contributor

All uses of NodeMainInstance::registry_ were removed in
43d2e24, so this change removes the variable completely.

Signed-off-by: Darshan Sen raisinten@gmail.com

cc @joyeecheung

@RaisinTen
src,bootstrap: remove NodeMainInstance::registry_
9bbcca5 
All uses of NodeMainInstance::registry_ were removed in
nodejs@43d2e24,
so this change removes the variable completely.

Signed-off-by: Darshan Sen <raisinten@gmail.com>
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. labels Jun 12, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 12, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 13, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @jasnell. Please 👍 to approve.

@github-actions github-actions bot mentioned this pull request Jun 14, 2022
Open
16 tasks
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
This was referenced Jun 15, 2022
Open
Open
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot mentioned this pull request Jun 17, 2022
Open
31 tasks
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot mentioned this pull request Jun 18, 2022
Open
34 tasks
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
This was referenced Jun 19, 2022
Open
Open
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
This was referenced Jun 21, 2022
Open
Open
@github-actions github-actions bot mentioned this pull request Jun 27, 2022
Open
33 tasks
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot mentioned this pull request Jun 28, 2022
Open
32 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44924/

@github-actions github-actions bot mentioned this pull request Jun 29, 2022
Open
23 tasks
@RaisinTen RaisinTen added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 29, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 29, 2022
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/43392
✔  Done loading data for nodejs/node/pull/43392
----------------------------------- PR info ------------------------------------
Title      src,bootstrap: remove `NodeMainInstance::registry_` (#43392)
Author     Darshan Sen  (@RaisinTen)
Branch     RaisinTen:src,bootstrap/remove-NodeMainInstance-registry_ -> nodejs:main
Labels     c++, process, fast-track, author ready, needs-ci
Commits    1
 - src,bootstrap: remove NodeMainInstance::registry_
Committers 1
 - Darshan Sen 
PR-URL: https://github.com/nodejs/node/pull/43392
Reviewed-By: Colin Ihrig 
Reviewed-By: Tobias Nießen 
Reviewed-By: Santiago Gimeno 
Reviewed-By: Joyee Cheung 
Reviewed-By: James M Snell 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/43392
Reviewed-By: Colin Ihrig 
Reviewed-By: Tobias Nießen 
Reviewed-By: Santiago Gimeno 
Reviewed-By: Joyee Cheung 
Reviewed-By: James M Snell 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 12 Jun 2022 13:20:52 GMT
   ✔  Approvals: 5
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/43392#pullrequestreview-1003640736
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/43392#pullrequestreview-1003645749
   ✔  - Santiago Gimeno (@santigimeno): https://github.com/nodejs/node/pull/43392#pullrequestreview-1003648118
   ✔  - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/43392#pullrequestreview-1003985797
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/43392#pullrequestreview-1004606591
   ℹ  This PR is being fast-tracked
   ✖  The fast-track request requires at least one collaborator's approval (👍).
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-06-28T04:38:55Z: https://ci.nodejs.org/job/node-test-pull-request/44924/
- Querying data for job/node-test-pull-request/44924/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/2583705616

@RaisinTen RaisinTen added commit-queue Add this label to land a pull request using GitHub Actions. and removed fast-track PRs that do not need to wait for 48 hours to land. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jun 29, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 29, 2022
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/43392
✖  Failed to get collaborator info from nodejs/node/README.md
Error: Couldn't find ### TSC (Technical Steering Committee) in the README
    at parseCollaborators (file:///opt/hostedtoolcache/node/16.15.1/x64/lib/node_modules/node-core-utils/lib/collaborators.js:81:11)
    at getCollaborators (file:///opt/hostedtoolcache/node/16.15.1/x64/lib/node_modules/node-core-utils/lib/collaborators.js:59:21)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async PRData.getCollaborators (file:///opt/hostedtoolcache/node/16.15.1/x64/lib/node_modules/node-core-utils/lib/pr_data.js:74:26)
    at async Promise.all (index 0)
    at async PRData.getAll (file:///opt/hostedtoolcache/node/16.15.1/x64/lib/node_modules/node-core-utils/lib/pr_data.js:58:5)
    at async getMetadata (file:///opt/hostedtoolcache/node/16.15.1/x64/lib/node_modules/node-core-utils/components/metadata.js:18:3)
    at async main (file:///opt/hostedtoolcache/node/16.15.1/x64/lib/node_modules/node-core-utils/components/git/land.js:200:22)
https://github.com/nodejs/node/actions/runs/2583778187

@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jun 30, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 30, 2022
@nodejs-github-bot nodejs-github-bot merged commit 08c8e85 into nodejs:main Jun 30, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 08c8e85

@RaisinTen RaisinTen deleted the src,bootstrap/remove-NodeMainInstance-registry_ branch June 30, 2022 08:35
targos pushed a commit that referenced this pull request Jul 12, 2022
@RaisinTen @targos
src,bootstrap: remove NodeMainInstance::registry_
48ee6b9 
All uses of NodeMainInstance::registry_ were removed in
43d2e24,
so this change removes the variable completely.

Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: #43392
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Jul 12, 2022
Merged
targos pushed a commit that referenced this pull request Jul 20, 2022
@RaisinTen @targos
src,bootstrap: remove NodeMainInstance::registry_
ffe7654 
All uses of NodeMainInstance::registry_ were removed in
43d2e24,
so this change removes the variable completely.

Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: #43392
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
@RaisinTen @targos
src,bootstrap: remove NodeMainInstance::registry_
6353a4d 
All uses of NodeMainInstance::registry_ were removed in
43d2e24,
so this change removes the variable completely.

Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: #43392
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@RaisinTen @guangwong
src,bootstrap: remove NodeMainInstance::registry_
c93ee8b 
All uses of NodeMainInstance::registry_ were removed in
nodejs/node@43d2e24,
so this change removes the variable completely.

Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: nodejs/node#43392
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@santigimeno santigimeno santigimeno approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@RaisinTen @nodejs-github-bot @jasnell @santigimeno @cjihrig @tniessen @joyeecheung @aduh95