-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: update lint-md-dependencies to rollup@2.75.6 #43386
Merged
nodejs-github-bot
merged 2 commits into
main
from
actions/tools-update-lint-md-dependencies
Jun 16, 2022
Merged
tools: update lint-md-dependencies to rollup@2.75.6 #43386
nodejs-github-bot
merged 2 commits into
main
from
actions/tools-update-lint-md-dependencies
Jun 16, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
added
fast-track
PRs that do not need to wait for 48 hours to land.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Jun 12, 2022
Trott
approved these changes
Jun 12, 2022
Fast-track has been requested by @Trott. Please 👍 to approve. |
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Jun 12, 2022
This comment was marked as outdated.
This comment was marked as outdated.
lpinca
approved these changes
Jun 12, 2022
VoltrexKeyva
approved these changes
Jun 12, 2022
Mesteery
approved these changes
Jun 12, 2022
tniessen
approved these changes
Jun 12, 2022
jasnell
approved these changes
Jun 13, 2022
This comment was marked as outdated.
This comment was marked as outdated.
16 tasks
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced Jun 15, 2022
Trott
added
commit-queue
Add this label to land a pull request using GitHub Actions.
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
labels
Jun 16, 2022
nodejs-github-bot
added
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
and removed
commit-queue
Add this label to land a pull request using GitHub Actions.
labels
Jun 16, 2022
Commit Queue failed- Loading data for nodejs/node/pull/43386 ✔ Done loading data for nodejs/node/pull/43386 ----------------------------------- PR info ------------------------------------ Title tools: update lint-md-dependencies to rollup@2.75.6 (#43386) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch nodejs-github-bot:actions/tools-update-lint-md-dependencies -> nodejs:main Labels tools, fast-track, commit-queue-squash Commits 2 - tools: update lint-md-dependencies to rollup@2.75.6 - tools: update lint-md-dependencies to rollup@2.75.6 Committers 1 - Node.js GitHub Bot PR-URL: https://github.com/nodejs/node/pull/43386 Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Mestery Reviewed-By: Tobias Nießen Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/43386 Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Mestery Reviewed-By: Tobias Nießen Reviewed-By: James M Snell -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - tools: update lint-md-dependencies to rollup@2.75.6 ℹ This PR was created on Sun, 12 Jun 2022 00:26:10 GMT ✔ Approvals: 6 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/43386#pullrequestreview-1003512663 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/43386#pullrequestreview-1003546774 ✔ - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/43386#pullrequestreview-1003562668 ✔ - Mestery (@Mesteery): https://github.com/nodejs/node/pull/43386#pullrequestreview-1003641645 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/43386#pullrequestreview-1003646143 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/43386#pullrequestreview-1004615454 ℹ This PR is being fast-tracked ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2506314375 |
Trott
approved these changes
Jun 16, 2022
Trott
added
commit-queue
Add this label to land a pull request using GitHub Actions.
and removed
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
labels
Jun 16, 2022
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Jun 16, 2022
Landed in 72f9597 |
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
PR-URL: #43386 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 18, 2022
PR-URL: #43386 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
PR-URL: #43386 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#43386 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
fast-track
PRs that do not need to wait for 48 hours to land.
tools
Issues and PRs related to the tools directory.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated update of lint-md-dependencies to rollup@2.75.6.