Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update packages documentation for Node.js 12 EOL #43375
doc: update packages documentation for Node.js 12 EOL #43375
Changes from 3 commits
4759735
4fad6db
924c758
894a104
5cb9eda
47c501a
2c9d7c3
b65c5e5
e102fce
f4184d6
9db527f
4cbd77f
d339608
c83484f
2dec621
074c1f5
a196e03
82ce47c
d8a9064
b9ffef7
5096cc7
21263f2
469e5e8
f2b426a
7804776
ad0861f
14a9f4e
eebd97d
b0a0df3
03e84ea
757bb60
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i still think these examples shouldn't be changed to add the extension.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don’t really understand what’s motivating this change either, if anything that adds more bloat to the import maps – I mean it adds 3 bytes; jokes aside, it could give the reader the impression that using an extension is required when defining an export path, and/or confuse needlessly the package consumers on why the is no
submodule.js
file at the trot of the package – whereas extensionless makes a good job signaling we’re not dealing with actual paths imo.(Same thing for the change
main.js
->index.js
, I don’t think it’s necessary)That being said, I don’t feel strongly about this, so feel free to disregard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.