Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update addons.markdown #4331

Closed
wants to merge 1 commit into from
Closed

Update addons.markdown #4331

wants to merge 1 commit into from

Conversation

secretfader
Copy link
Contributor

update link from github.com/rvagg to github.com/nodejs, to remove stale URI.

update link from github.com/rvagg to github.com/nodejs
@jasnell
Copy link
Member

jasnell commented Dec 17, 2015

LGTM

@jasnell jasnell added the doc Issues and PRs related to the documentations. label Dec 17, 2015
jasnell pushed a commit that referenced this pull request Dec 17, 2015
Update link from github.com/rvagg to github.com/nodejs

PR-URL: #4331
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Dec 17, 2015

Landed in 4637168

@secretfader
Copy link
Contributor Author

@jasnell FYI: this is present in docs for the current release as well. (I saw the lts-watch tag, and want to make sure it will update the link in every relevant release.)

@secretfader secretfader deleted the patch-1 branch December 17, 2015 17:23
@secretfader secretfader restored the patch-1 branch December 17, 2015 17:24
@jasnell
Copy link
Member

jasnell commented Dec 17, 2015

Yep. Will definitely make sure it lands in v4. Will need someone to pull it into v5 also

@jasnell jasnell mentioned this pull request Dec 17, 2015
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Dec 22, 2015
Update link from github.com/rvagg to github.com/nodejs

PR-URL: nodejs#4331
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 30, 2015
Update link from github.com/rvagg to github.com/nodejs

PR-URL: #4331
Reviewed-By: James M Snell <jasnell@gmail.com>
@rvagg
Copy link
Member

rvagg commented Jan 4, 2016

Thanks for this @nicholaswyoung, I believe this is your first commit to core and even though the change is trivial we appreciate the attention to detail. Welcome on board, we hope you stick around and can find other ways to contribute.

@secretfader
Copy link
Contributor Author

@rvagg It is. I don't know why I waited this long to send a patch, but with the warm welcome that I received—I don't think it will be my last!

Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Jan 6, 2016
Update link from github.com/rvagg to github.com/nodejs

PR-URL: nodejs#4331
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
Update link from github.com/rvagg to github.com/nodejs

PR-URL: #4331
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 19, 2016
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
Update link from github.com/rvagg to github.com/nodejs

PR-URL: nodejs#4331
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants