Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esm: fix chain advances when loader calls next<HookName> multiple times #43303

Merged
merged 2 commits into from
Jun 5, 2022
Merged

esm: fix chain advances when loader calls next<HookName> multiple times #43303

merged 2 commits into from
Jun 5, 2022

Conversation

JakobJingleheimer
Copy link
Contributor

fixes #43238

@JakobJingleheimer JakobJingleheimer added esm Issues and PRs related to the ECMAScript Modules implementation. loaders Issues and PRs related to ES module loaders labels Jun 2, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 2, 2022 •
edited by JakobJingleheimer
Loading

Review requested:

  • @nodejs/loaders
  • @nodejs/modules

@nodejs-github-bot nodejs-github-bot added errors Issues and PRs related to JavaScript errors originated in Node.js core. needs-ci PRs that need a full CI run. labels Jun 2, 2022
@JakobJingleheimer

This comment was marked as resolved.

Sign in to view
@JakobJingleheimer JakobJingleheimer force-pushed the esm/fix-multiple-next-calls-advancing-chain branch from 3cf8f28 to 9099755 Compare June 2, 2022 22:01
GeoffreyBooth
GeoffreyBooth reviewed Jun 2, 2022
View reviewed changes
lib/internal/modules/esm/loader.js Show resolved Hide resolved
lib/internal/modules/esm/loader.js Outdated Show resolved Hide resolved
lib/internal/modules/esm/loader.js Show resolved Hide resolved
lib/internal/modules/esm/loader.js Outdated Show resolved Hide resolved
aduh95
aduh95 reviewed Jun 3, 2022
View reviewed changes
lib/internal/modules/esm/loader.js Outdated Show resolved Hide resolved
lib/internal/modules/esm/loader.js Outdated Show resolved Hide resolved
GeoffreyBooth
GeoffreyBooth reviewed Jun 3, 2022
View reviewed changes
lib/internal/modules/esm/loader.js Outdated Show resolved Hide resolved
lib/internal/modules/esm/loader.js Outdated Show resolved Hide resolved
lib/internal/modules/esm/loader.js Show resolved Hide resolved
@JakobJingleheimer JakobJingleheimer force-pushed the esm/fix-multiple-next-calls-advancing-chain branch from 910d4ff to 4a2969b Compare June 4, 2022 09:23
@JakobJingleheimer JakobJingleheimer added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 4, 2022
@JakobJingleheimer
Copy link
Contributor Author

@tniessen is the current test failure something I can ignore? I can’t see how it’s related (and it affects only 1 system). Rich and I both tried re-triggering it, but it timed out again both times.

GitHub Actions
/ test-asan
test/parallel/test-cluster-primary-kill.js#L1
Command: out/Release/node /home/runner/work/node/node/test/parallel/test-cluster-primary-kill.js
--- TIMEOUT ---

https://github.com/nodejs/node/pull/43303/files#diff-08e6bc52a7fd6d16a58fc1a7fea64758fcf0481cc4ecff14618824c0239814fa

@JakobJingleheimer JakobJingleheimer added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 5, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 5, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44361/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44362/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44363/

@tniessen
Copy link
Member

tniessen commented Jun 5, 2022

@JakobJingleheimer No, sorry. As long as nobody fixes the underlying issue, we'll have to keep retrying.

@JakobJingleheimer
Copy link
Contributor Author

JakobJingleheimer commented Jun 5, 2022 •
edited
Loading

Sorry, are you saying it's signalling a legit problem in the PR or there is a problem in the test?

If the former, do we have any idea where/why the test has a problem? (Is it tracked? I might try to fix it)

If the latter, can I just add the label and otherwise ignore it?

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44365/

@Trott
Copy link
Member

Trott commented Jun 5, 2022

Looks like it passed on the 4th run.

If the latter, can I just add the label and otherwise ignore it?

The commit queue won't land something if a GitHub Action failed.

@aduh95
Copy link
Contributor

aduh95 commented Jun 5, 2022

If the latter, can I just add the label and otherwise ignore it?

What label? In order for a PR to land, all the GitHub Actions CIs must be green, and depending if the PR content affects the node binary, a passing Jenkins CI. The CQ won't land a PR if it doesn't meet this requirement.
If by "ignoring it", you mean re-spawn the test-asan job until it ends up green, then sure you can do that (btw it's green now).

The ASan CI has been very flaky lately (https://github.com/nodejs/node/issues?q=is%3Aissue+asan+is%3Aopen+label%3Aflaky-test), which is a pain but as Tobias said, it's something we have to suffer until someone addresses the underlying issue(s).

@JakobJingleheimer
Copy link
Contributor Author

Oh, I was thinking commit-queue-failed, which isn't right.

Ah, cool; I'll wait for the remaining actions to finish. Thanks!

@JakobJingleheimer JakobJingleheimer added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 5, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 5, 2022
@nodejs-github-bot nodejs-github-bot merged commit 765666a into nodejs:master Jun 5, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 765666a

@JakobJingleheimer JakobJingleheimer added the backport-blocked-v18.x PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport. label Jun 5, 2022
@JakobJingleheimer
Copy link
Contributor Author

Backport blocked by #42623 (which is itself blocked for backport)

italojs pushed a commit to italojs/node that referenced this pull request Jun 6, 2022
@JakobJingleheimer @italojs
esm: fix chain advances when loader calls next<HookName> multiple times
335a943 
PR-URL: nodejs#43303
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Jun 11, 2022
@JakobJingleheimer @danielleadams
esm: fix chain advances when loader calls next<HookName> multiple times
601d933 
PR-URL: #43303
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@danielleadams danielleadams mentioned this pull request Jun 11, 2022
Merged
@JakobJingleheimer JakobJingleheimer mentioned this pull request Jun 15, 2022
Merged
@JakobJingleheimer JakobJingleheimer removed the backport-blocked-v18.x PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport. label Jun 18, 2022
targos pushed a commit that referenced this pull request Jul 12, 2022
@JakobJingleheimer @targos
esm: fix chain advances when loader calls next<HookName> multiple times
10bcad5 
PR-URL: #43303
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targos targos mentioned this pull request Jul 12, 2022
Merged
targos pushed a commit that referenced this pull request Jul 19, 2022
@JakobJingleheimer @targos
esm: fix chain advances when loader calls next<HookName> multiple times
4c726b0 
PR-URL: #43303
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
@JakobJingleheimer @targos
esm: fix chain advances when loader calls next<HookName> multiple times
df3f5cb 
PR-URL: #43303
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@JakobJingleheimer @guangwong
esm: fix chain advances when loader calls next<HookName> multiple times
066c3e9 
PR-URL: nodejs/node#43303
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@Changqing-JING Changqing-JING mentioned this pull request Jun 9, 2023
Merged
@JakobJingleheimer JakobJingleheimer mentioned this pull request Jul 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb left review comments

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes

@aduh95 aduh95 aduh95 approved these changes

@guybedford guybedford Awaiting requested review from guybedford

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. errors Issues and PRs related to JavaScript errors originated in Node.js core. esm Issues and PRs related to the ECMAScript Modules implementation. loaders Issues and PRs related to ES module loaders needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

esm custom loader: multiple calls to nextHook within the same loader result in different nextHooks
7 participants
@JakobJingleheimer @nodejs-github-bot @tniessen @Trott @aduh95 @ljharb @GeoffreyBooth