Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix Visual Studio 2019 download link #43236

Merged
merged 1 commit into from
Jun 21, 2022

Conversation

F3n67u
Copy link
Member

@F3n67u F3n67u commented May 29, 2022

Background: Building Node.js with Visual Studio 2022 is broken from Visual Studio 17.2, see #43092.

The https://visualstudio.microsoft.com/downloads/ now link to the latest Visual Studio 2022 version instead of 2019 is incorrect. If our windows new contributor follows the link and downloads the Visual Studio 2022, build will fail. I follow this link and download the 2022 version yesterday😂 and experience build failure.

https://visualstudio.microsoft.com/downloads/#build-tools-for-visual-studio-2019 link is also broken, I cannot find a link to build-tools-for-visual-studio-2019 to replace it, so I delete the [Build Tools] link. If #43092 is resolved, we could add it again. or If anyone could find the link to build-tools-for-visual-studio-2019, please comment and I will add it.

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels May 29, 2022
the "C++ build tools" workload from the
[Build Tools](https://visualstudio.microsoft.com/downloads/#build-tools-for-visual-studio-2019),
[Build Tools](https://aka.ms/vs/16/release/vs_buildtools.exe),
Copy link
Member Author

@F3n67u F3n67u May 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://visualstudio.microsoft.com/downloads/#build-tools-for-visual-studio-2019 link is also broken, I cannot find a visual studio 2019 c++ build tools link from https://visualstudio.microsoft.com/downloads.

Using https://aka.ms/vs/16/release/vs_buildtools.exe link to download visual studio 2019 build tools is documented at
https://docs.microsoft.com/en-us/visualstudio/install/build-tools-container?view=vs-2019#create-and-build-the-dockerfile.

image

I have verified this link does works on my windows server: uninstall already installed visual studio 2019, install build tool via the build tools link, and verify .\vcbuild does compile.

@F3n67u F3n67u requested a review from targos June 11, 2022 15:42
@F3n67u
Copy link
Member Author

F3n67u commented Jun 19, 2022

@targos could you please take a look at this pr?

@F3n67u
Copy link
Member Author

F3n67u commented Jun 21, 2022

Hi @targo, could you help to land this pr? Thanks.

@targos targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 21, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 21, 2022
@nodejs-github-bot nodejs-github-bot merged commit 08d6a82 into nodejs:main Jun 21, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 08d6a82

@F3n67u F3n67u deleted the fix/vs2019-link branch June 21, 2022 07:41
codebytere pushed a commit to codebytere/node that referenced this pull request Jun 21, 2022
PR-URL: nodejs#43236
Reviewed-By: Michaël Zasso <targos@protonmail.com>
F3n67u added a commit to F3n67u/node that referenced this pull request Jun 24, 2022
PR-URL: nodejs#43236
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit that referenced this pull request Jul 12, 2022
PR-URL: #43236
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit that referenced this pull request Jul 20, 2022
PR-URL: #43236
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
PR-URL: #43236
Reviewed-By: Michaël Zasso <targos@protonmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
PR-URL: nodejs/node#43236
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants