-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: upgrade npm to 8.10.0 #43061
deps: upgrade npm to 8.10.0 #43061
Conversation
Fast-track has been requested by @nodejs-github-bot. Please 👍 to approve. |
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM
Commit Queue failed- Loading data for nodejs/node/pull/43061 ✔ Done loading data for nodejs/node/pull/43061 ----------------------------------- PR info ------------------------------------ Title deps: upgrade npm to 8.10.0 (#43061) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch npm-cli-bot:npm-8.10.0 -> nodejs:master Labels npm, fast-track, needs-ci, dont-land-on-v14.x Commits 1 - deps: upgrade npm to 8.10.0 Committers 1 - npm-cli+bot@github.com PR-URL: https://github.com/nodejs/node/pull/43061 Reviewed-By: Ruy Adorno Reviewed-By: Tobias Nießen Reviewed-By: Luigi Pinca Reviewed-By: Mohammed Keyvanzadeh ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/43061 Reviewed-By: Ruy Adorno Reviewed-By: Tobias Nießen Reviewed-By: Luigi Pinca Reviewed-By: Mohammed Keyvanzadeh -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 11 May 2022 17:17:21 GMT ✔ Approvals: 4 ✔ - Ruy Adorno (@ruyadorno): https://github.com/nodejs/node/pull/43061#pullrequestreview-969793434 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/43061#pullrequestreview-969847804 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/43061#pullrequestreview-969897537 ✔ - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/43061#pullrequestreview-970082411 ℹ This PR is being fast-tracked ⚠ GitHub cannot link the author of 'deps: upgrade npm to 8.10.0' to their GitHub account. ⚠ Please suggest them to take a look at https://github.com/nodejs/node/blob/99b1ada/doc/guides/contributing/pull-requests.md#step-1-fork ✖ Last GitHub CI failed ℹ Last Full PR CI on 2022-05-11T18:16:38Z: https://ci.nodejs.org/job/node-test-pull-request/43962/ - Querying data for job/node-test-pull-request/43962/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2334046116 |
Thanks @wraithgar! |
I clicked the button in the github ui so it did a merge commit, not a rebase. idk if that matters here but now you know. |
I'm not sure this will work 🤔 I'll go ahead and rebase the commit to be sure 😊 |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Commit Queue failed- Loading data for nodejs/node/pull/43061 ✔ Done loading data for nodejs/node/pull/43061 ----------------------------------- PR info ------------------------------------ Title deps: upgrade npm to 8.10.0 (#43061) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch npm-cli-bot:npm-8.10.0 -> nodejs:master Labels npm, fast-track, needs-ci, dont-land-on-v14.x Commits 1 - deps: upgrade npm to 8.10.0 Committers 1 - Ruy Adorno PR-URL: https://github.com/nodejs/node/pull/43061 Reviewed-By: Ruy Adorno Reviewed-By: Tobias Nießen Reviewed-By: Luigi Pinca Reviewed-By: Mohammed Keyvanzadeh ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/43061 Reviewed-By: Ruy Adorno Reviewed-By: Tobias Nießen Reviewed-By: Luigi Pinca Reviewed-By: Mohammed Keyvanzadeh -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - deps: upgrade npm to 8.10.0 ℹ This PR was created on Wed, 11 May 2022 17:17:21 GMT ✔ Approvals: 4 ✔ - Ruy Adorno (@ruyadorno): https://github.com/nodejs/node/pull/43061#pullrequestreview-969793434 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/43061#pullrequestreview-969847804 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/43061#pullrequestreview-969897537 ✔ - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/43061#pullrequestreview-970082411 ℹ This PR is being fast-tracked ⚠ GitHub cannot link the author of 'deps: upgrade npm to 8.10.0' to their GitHub account. ⚠ Please suggest them to take a look at https://github.com/nodejs/node/blob/99b1ada/doc/guides/contributing/pull-requests.md#step-1-fork ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-05-18T14:21:53Z: https://ci.nodejs.org/job/node-test-pull-request/44067/ - Querying data for job/node-test-pull-request/44067/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2346657102 |
Landed in 06dd8c3. |
PR-URL: #43061 Reviewed-By: Ruy Adorno <ruyadorno@github.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
PR-URL: #43061 Reviewed-By: Ruy Adorno <ruyadorno@github.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
PR-URL: #43061 Reviewed-By: Ruy Adorno <ruyadorno@github.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
PR-URL: #43061 Reviewed-By: Ruy Adorno <ruyadorno@github.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
PR-URL: #43061 Reviewed-By: Ruy Adorno <ruyadorno@github.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
v8.10.0 (2022-05-11)
Features
911f55d
#4864 feat: add --iwr alias for --include-workspace-root (@fritzy)bfb8bcc
#4874 feat: add flag --omit-lockfile-registry-resolved (@fritzy) (Caleb ツ Everett)Bug Fixes
48d2db6
#4862 fix: remove test coverage map (@wraithgar)38cf29a
#4868 fix: cleanup star/unstar (@wraithgar)5baa4a7
#4857 fix: consolidate bugs, docs, repo command logic (@wraithgar)5a50762
#4875 fix(arborist): link deps lifecycle scripts (@ruyadorno)Dependencies
d58bf40
#4856 deps:npm-packlist@5.0.3
86f443e
#4872 deps:make-fetch-happen@10.1.3
f9984e6
#4880 deps:@npmcli/arborist@5.2.0
ba59915
#4881 deps:socks-proxy-agent@6.2.0
c0806ba
#4881 deps:http-proxy-agent@5.0.1
cc7be6b
#4881 deps:is-core-module@2.9.0
0432c7d
#4881 deps:lru-cache@7.9.0
5778820
#4881 deps:just-diff@5.0.2
893dd00
#4881 deps:ip@1.1.8
6ab85bd
#4881 deps:builtins@5.0.1