test: improve lib/internal/source_map/source_map.js coverage #42771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
jasnell
approved these changes
Apr 20, 2022
fossamagna
force-pushed
the
test-source-map-api
branch
from
eb36738 to
a0fcb9d
Compare
fossamagna
force-pushed
the
test-source-map-api
branch
from
a0fcb9d to
b821123
Compare
fossamagna
force-pushed
the
test-source-map-api
branch
from
b821123 to
199a2ca
Compare
|
@jasnell I rebased top of main in test-source-map-api branch. It looks like there were nothing failures in the CI, Is there anything blocking to merging this PR? |
cola119
approved these changes
Oct 1, 2022
github-actions
bot
removed
the
request-ci
github-actions
bot
removed
the
request-ci
cola119
added
author ready
nodejs-github-bot
removed
the
commit-queue
|
Landed in f4815fc |
danielleadams
pushed a commit
that referenced
this pull request
Oct 11, 2022
PR-URL: #42771 Refs: https://coverage.nodejs.org/coverage-0699150267c08fb2/lib/internal/source_map/source_map.js.html#L154 Refs: https://coverage.nodejs.org/coverage-0699150267c08fb2/lib/internal/source_map/source_map.js.html#L165 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves a test coverage in
lib/internal/source_map/source_map.jscoverageRef: https://coverage.nodejs.org/coverage-0699150267c08fb2/lib/internal/source_map/source_map.js.html#L154
Ref: https://coverage.nodejs.org/coverage-0699150267c08fb2/lib/internal/source_map/source_map.js.html#L165
This validates that index source map is supported.